Bug 22521 changes the accounttype values for fines and adds a new status field. cash_register_stats.pl does not use these new values. To test: - use the fines cron to generate new accounttype OVERDUE - go to cash_register_stats.pl and run a report for transaction type Fine - observe that none of your fines show in the report, as it is looking for accounttype=F/FU This also impacts stable.
Created attachment 94299 [details] [review] Bug 23827: Correction for missed 'F' and 'FU' case When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed the cases inside the cash_register_stats template. This patch should correct that mistake.
That should do the trick.
Created attachment 94305 [details] [review] Bug 23827: Correction for missed 'F' and 'FU' case [19.05] When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed the cases inside the cash_register_stats template. This patch should correct that mistake. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
- created a circ rule that includes fines - checked out an item with a due date in the past - checked that item back in - verified patron had a fine - verified that fine shows in cash register stats when filtering for Fine
Thanks for jumping right on this, Martin!
"OVERDUEA"? I suspect a typo here.
(In reply to Jonathan Druart from comment #6) > "OVERDUEA"? I suspect a typo here. OVERDUEA = OVERDUE ACCRUING (UNRETURNED)
(In reply to Nick Clemens from comment #7) > (In reply to Jonathan Druart from comment #6) > > "OVERDUEA"? I suspect a typo here. > > OVERDUEA = OVERDUE ACCRUING (UNRETURNED) Where did you find that? git grep 'OVERDUEA' git grep 'OVERDUE ACCRUING' => No result.
(In reply to Jonathan Druart from comment #8) > (In reply to Nick Clemens from comment #7) > > (In reply to Jonathan Druart from comment #6) > > > "OVERDUEA"? I suspect a typo here. > > > > OVERDUEA = OVERDUE ACCRUING (UNRETURNED) > > Where did you find that? > > git grep 'OVERDUEA' > git grep 'OVERDUE ACCRUING' > => No result. It was in the code later, that is how I understood it: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94305&action=diff#a/reports/cash_register_stats.pl_sec1
We are testing if $transaction_type eq 'OVERDUEA', ok. But where is it set to this value?
(In reply to Jonathan Druart from comment #10) > We are testing if $transaction_type eq 'OVERDUEA', ok. > > But where is it set to this value? ok ok, forget that. I get it now, thanks Nick!
Can you rebase it please?
Setting this bug to 19.05 as in master it's rather different.. I'm going to double-check the logic in current master before creating a new bug to record an issue there if I find one.
QAing
CONFLICT (content): Merge conflict in reports/cash_register_stats.pl CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
Created attachment 95130 [details] [review] Bug 23827: Correction for missed 'F' and 'FU' case When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed the cases inside the cash_register_stats template. This patch should correct that mistake. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
It applies to 19.05 fine for me.. this bug is for 19.05.x (and below) only.
QA generally skips patches for older versions. Change status in order to put it on the list of the appropriate RMaint ?
this was backported to 19.05.x for 19.05.05 on 11/22/19