When you go into Administration > Authorised values, there are descriptions for each auth value category. The description of Bsort1 says that it is used for sort 2 field. It should say that it is used for sort 1. I also noticed that Asort1 and Asort2 have the same description, but Bsort1 and Bsort2 do not.
Created attachment 94454 [details] [review] Bug 23853: Typo in authorised_values.tt This patch corrects the Bsort1 typo in authorised_values.tt and changes the Bsort2 description to match Bsort1's. To test: 1- Go to Administration > Authorised values 2- Make sure descriptions for Bsort1 and Bsort2 match their category and are the same (except for 1 and 2)
Created attachment 94820 [details] [review] Bug 23853: Typo in authorised_values.tt This patch corrects the Bsort1 typo in authorised_values.tt and changes the Bsort2 description to match Bsort1's. To test: 1- Go to Administration > Authorised values 2- Make sure descriptions for Bsort1 and Bsort2 match their category and are the same (except for 1 and 2) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Nice catch Caroline ! Works fine for me :)
Created attachment 94828 [details] [review] Bug 23853: Typo in authorised_values.tt This patch corrects the Bsort1 typo in authorised_values.tt and changes the Bsort2 description to match Bsort1's. To test: 1- Go to Administration > Authorised values 2- Make sure descriptions for Bsort1 and Bsort2 match their category and are the same (except for 1 and 2) Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good catch, passing QA
Nice work! Pushed to master for 19.11.00