Enabling and configuring "EnablePayPalOpacPayments PayPalSandboxMode" works fine. But when it comes to paying a fine in the OPAC, the "Make payment" button is never enabled. It is disabled initially, but is supposed to be enabled if at least one fine is selected to be paid. This it the line that is supposed to enable it (now commented out): https://github.com/PTFS-Europe/koha/blob/master/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt#L104 it was commented out as part of Bug 23213 - is this an oversight or is this functionality now superseded?
Looking further into it, I think my initial conclusion was wrong. Uncommenting that line doesn't cause the button to be enabled when a fine is selected. There is reference to elements with a `data-threshold` attribute, which I cannot find in my markup, so I am now wondering if this PayPal functionality is dependent on the plugins mentioned in Bug 23213. In short, I'm confused!
Tomas or Kyle, can you help here?
Created attachment 95029 [details] [review] Bug 23868: Check if threshold is undefined in javascript block of opac-account.tt This patch fixes a bug introduced by checking payment plugins threshold To test: 1. do not apply this patch 2. configure paypal options in intranet 3. create a manual invoice for a patron 4. in opac try to pay that invoice CHECK => Make Payment button is disabled, even when invoices where checked. 5. apply this patch 6. repeat step 4 SUCCESS => Make Payment button is enabled when an invoice is checked. 7. Sign off
Created attachment 95066 [details] [review] Bug 23868: Check if threshold is undefined in javascript block of opac-account.tt This patch fixes a bug introduced by checking payment plugins threshold To test: 1. do not apply this patch 2. configure paypal options in intranet 3. create a manual invoice for a patron 4. in opac try to pay that invoice CHECK => Make Payment button is disabled, even when invoices where checked. 5. apply this patch 6. repeat step 4 SUCCESS => Make Payment button is enabled when an invoice is checked. 7. Sign off Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 95119 [details] [review] Bug 23868: Check if threshold is undefined in javascript block of opac-account.tt This patch fixes a bug introduced by checking payment plugins threshold To test: 1. do not apply this patch 2. configure paypal options in intranet 3. create a manual invoice for a patron 4. in opac try to pay that invoice CHECK => Make Payment button is disabled, even when invoices where checked. 5. apply this patch 6. repeat step 4 SUCCESS => Make Payment button is enabled when an invoice is checked. 7. Sign off Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Just changing: String patch = Interface/GUI strings, changing to Trivial.
Nice work! Pushed to master for 19.11.00
Depends on Bug 23213 not in 19.05.x