In the specification for the GIR segment it states If there are more than five items of information for one copy or for one part order, the segment may be repeated with the same copy or part-order sequence number in DE 7297 This was something we initially did not need to do as we have limited locations to store GIR data. This is no longer the case as some sites are using this for other data codes, so we need to implement the standard format
note some suppliers' software cannot process orders containing incorrectly formatted GIR segments
Created attachment 94874 [details] [review] Patch correcting GIR format and test cases To test - Tests of the functionality in t/Ediorder.t, as routine does not require db connection can run in a development environment
Adding Kyle to the CC list as one of the few other people out there able to work on and test EDI patches.
(In reply to Martin Renvoize from comment #3) > Adding Kyle to the CC list as one of the few other people out there able to > work on and test EDI patches. This change will not affect the EDI plugins I maintain. In fact, in my plugins I made the GIR subfield limit configurable, as some vendors require the 5 field limit and so do not.
Created attachment 100338 [details] [review] Bug 23926 Limit GIR segment to 5 pieces of info Strictly if a GIR segment contains more than 5 pieces of information the it should be encoded in repeated segments each of 5 elements or less each sharing the same copy sequence number Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I'm going to knock this one up to PQA as the two people most authoritative about EDI have now been involved :)
Nice work everyone! Pushed to master for 20.05
I get a Fail on qa when applying this patch FAIL Koha/Edifact/Order.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage FAIL spelling dont ==> don't dont ==> don't dont ==> don't dont ==> don't OK valid not backporting to 19.11.x