Bug 23928 - Move saved reports JavaScript into separate file
Summary: Move saved reports JavaScript into separate file
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-30 16:40 UTC by Owen Leonard
Modified: 2023-08-23 05:18 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2019-10-30 16:40:58 UTC 
Coding guideline JS1 (https://wiki.koha-community.org/wiki/Coding_Guidelines#JS1:_Embedding_JavaScript_blocks_in_templates) says "Whenever possible JavaScript should be placed in a separate file."

I propose to move most of the JS embedded in reports/guided_reports_start.tt to a separate file.
Comment 1 David Cook 2023-08-23 05:18:46 UTC 
I didn't realize that we had a coding guideline for this. That's awesome. I'd really like us to make more of an effort on this one to enable Content-Security-Policy going forward.