In looking for places in the templates where we still refer to famfamfam icons I found some inline CSS in the suggestions management page. A markup mis-match means that this style hasn't been correctly applied. I would like to modify the CSS and markup so that the note stands out from the other info in the suggestions list and replace the background image icon with a Font Awesome icon.
Created attachment 94982 [details] [review] Bug 23954: Format notes in suggestion management This patch makes minor CSS and markup changes in order to deliniate suggestion notes from the other data in the suggestions list view. To test you should have at least one suggestion with a note. Apply the patch and go to Acquisitions -> Suggestions. In the table of suggestions, check that the notes display clearly.
Created attachment 94990 [details] [review] Bug 23954: Format notes in suggestion management This patch makes minor CSS and markup changes in order to deliniate suggestion notes from the other data in the suggestions list view. To test you should have at least one suggestion with a note. Apply the patch and go to Acquisitions -> Suggestions. In the table of suggestions, check that the notes display clearly. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 95140 [details] [review] Bug 23954: Format notes in suggestion management This patch makes minor CSS and markup changes in order to deliniate suggestion notes from the other data in the suggestions list view. To test you should have at least one suggestion with a note. Apply the patch and go to Acquisitions -> Suggestions. In the table of suggestions, check that the notes display clearly. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work! Pushed to master for 19.11.00
backported to 19.05.x for 19.05.06
Backported to 18.11.x for 18.11.12