The "No Status" in the status pull down on the suggestion edit form should be "No status".
Created attachment 95410 [details] [review] Bug 24034: Capitalization on suggestion edit form: No Status When editing a purchase suggestion, the "No status" option in the status pulldown is incorrectly capatalized. This patch fixes the capitazliation. To test: 1) Create a purchase suggestion in the acquisitions module. 2) Edit the suggestion. Notice the capitalization in the status dropdown is incorrect. 3) Apply the patch. 4) Repeat step 2. 5) Note the capitalization has been fixed. 6) Sign off.
Created attachment 95412 [details] [review] Bug 24034: Capitalization on suggestion edit form: No Status When editing a purchase suggestion, the "No status" option in the status pulldown is incorrectly capatalized. This patch fixes the capitazliation. To test: 1) Create a purchase suggestion in the Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 95442 [details] [review] Bug 24034: Capitalization on suggestion edit form: No Status When editing a purchase suggestion, the "No status" option in the status pulldown is incorrectly capatalized. This patch fixes the capitazliation. To test: 1) Create a purchase suggestion in the Signed-off-by: George Williams <george@nekls.org>
Created attachment 95447 [details] [review] Bug 24034: Capitalization on suggestion edit form: No Status When editing a purchase suggestion, the "No status" option in the status pulldown is incorrectly capatalized. This patch fixes the capitazliation. To test: 1) Create a purchase suggestion in the acquisitions module. 2) Edit the suggestion. Notice the capitalization in the status dropdown is incorrect. 3) Apply the patch. 4) Repeat step 2. 5) Note the capitalization has been fixed. 6) Sign off. Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Congratulations on your first patch, Lisette!
+1
I've decided to let this one slip through after string freeze.. it's a tiny change and it'll be nice to get Lisette into the release notes as a new contributor ;) Thanks for your efforts here, it's always nice to welcome a new contributor :)
Nice work! Pushed to master for 19.11.00