batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use search( \\%condition ) instead at /kohadevbox/koha/Koha/Objects.pm line 136: /kohadevbox/koha/tools/batchMod.pl, referer: http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run%20this%20report
Created attachment 95486 [details] [review] Bug 24051: Remove "search( %condition ) is deprecated" warning from batchMod.pl Test plan: Go to Home › Tools › Batch item modification Insert barcodes and continue => Without this patch you will get warning in the log => With this patch applied you warning does no longer appear Confirm that the number of holds is correct
Created attachment 98999 [details] [review] Bug 24051: Remove "search( %condition ) is deprecated" warning from batchMod.pl Test plan: Go to Home › Tools › Batch item modification Insert barcodes and continue => Without this patch you will get warning in the log => With this patch applied you warning does no longer appear Confirm that the number of holds is correct Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 99219 [details] [review] Bug 24051: Remove "search( %condition ) is deprecated" warning from batchMod.pl Test plan: Go to Home › Tools › Batch item modification Insert barcodes and continue => Without this patch you will get warning in the log => With this patch applied you warning does no longer appear Confirm that the number of holds is correct Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial and obvious fix. Passing QA
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.04
backported to 19.05.x. for 19.05.09