PayPalReturnURL says: After payment or cancellation, PayPal should return to the␠OPAC's alias It's not clear what is meant by OPAC's alias. Could this be rephrased or an example be added to make this clearer?
Hi Tomas, can you maybe help me out? What is the alias if it's not the BaseURL?
I think this refers to the situation in which the OPAC is behind (say) a reverse proxy, and for some reason we don't want the 'after PayPal finished redirect' to use the guessed URL, but a fixed one. I'd say 'alias' is too specific here. I'd say to the 'specified URL'.
Created attachment 102855 [details] [review] Bug 24055: Rephrase description of PayPalReturnURL slightly changes 'OPAC's alias' to 'specified URL' as suggested by Tomas on comment#2. To test: - Go to Administration / System preferences - Search for PayPalReturnURL - Verify description has changed to "specified URL" as one of the options
Created attachment 102945 [details] [review] Bug 24055: Rephrase description of PayPalReturnURL slightly changes 'OPAC's alias' to 'specified URL' as suggested by Tomas on comment#2. To test: - Go to Administration / System preferences - Search for PayPalReturnURL - Verify description has changed to "specified URL" as one of the options Signed-off-by: Michal Denar <black23@gmail.com>
I cant say that it is clear to me now. If we rephrase, please make it more clear than what we do now.
I followed Tomas suggestion, I will need help to find a better description as honestly I don't really understand myself. Just trying to push this forward to improve things here!
Created attachment 115495 [details] [review] Bug 24055: (follow-up) Description of PayPalReturnURL system preference Have rephrased it as 'configured return URL' as this is what they call it on the PayPal website. To test: - Go to Administration/ System preferences - Search for PayPalReturnURL - Verify description has changed to 'configured return URL' as one of the options. Sponsored.by: Catalyst IT
Created attachment 115599 [details] [review] Bug 24055: Rephrase description of PayPalReturnURL slightly changes 'OPAC's alias' to 'specified URL' as suggested by Tomas on comment#2. To test: - Go to Administration / System preferences - Search for PayPalReturnURL - Verify description has changed to "specified URL" as one of the options Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 115600 [details] [review] Bug 24055: (follow-up) Description of PayPalReturnURL system preference Have rephrased it as 'configured return URL' as this is what they call it on the PayPal website. To test: - Go to Administration/ System preferences - Search for PayPalReturnURL - Verify description has changed to 'configured return URL' as one of the options. Sponsored.by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Let's try this again, thx Ella!
Created attachment 115604 [details] [review] Bug 24055: Rephrase description of PayPalReturnURL slightly changes 'OPAC's alias' to 'specified URL' as suggested by Tomas on comment#2. To test: - Go to Administration / System preferences - Search for PayPalReturnURL - Verify description has changed to "specified URL" as one of the options Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 115605 [details] [review] Bug 24055: (follow-up) Description of PayPalReturnURL system preference Have rephrased it as 'configured return URL' as this is what they call it on the PayPal website. To test: - Go to Administration/ System preferences - Search for PayPalReturnURL - Verify description has changed to 'configured return URL' as one of the options. Sponsored.by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.