To allow searching for eg. Skolt Sami texts, some additional characters should be mapped in Zebra: Ǩ, ǯ, and ŋ.
Created attachment 95527 [details] [review] Bug 24063: Add Sami language characters to Zebra Some Sami languages need few more characters to be mapped, or are otherwise very hard to search for. Test plan: 1) Catalogue a new record with title "Ǩoǯeŋa" 2) Make sure zebra indexed that record, then try to search for it with the text "kozena" 3) Apply patch 4) Redo 2, now the record should be found.
Created attachment 95766 [details] [review] Bug 24063: Add Sami language characters to Zebra Some Sami languages need few more characters to be mapped, or are otherwise very hard to search for. Test plan: 1) Catalogue a new record with title "Ǩoǯeŋa" 2) Make sure zebra indexed that record, then try to search for it with the text "kozena" 3) Apply patch 4) Redo 2, now the record should be found. Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Simple patch, sitting for a month - passing QA.
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x for 19.11.02
simple enhancement, choosing to backport to 19.05.x series for 19.05.07
Enhancement will not be backported to 18.11.x series.
Created attachment 111790 [details] [review] Bug 24603: Allow to cancel charges in patron accounting There is already a button to void a payment. It should be possible to cancel a charge too. This patch adds a button in patron's accounting section (Transactions tab) that allow to cancel charges. Charges that have been fully or partially paid cannot be cancelled. It also fixes Koha::Account::Line::is_credit by looking at credit_type_code instead of amount (amount can be 0 for voided payments) It also fixes the tests for Koha::Account::Line::void when database does not contain the borrowernumber 51 (the default in t::lib::Mocks::mock_userenv) Test plan: 1. Go to a patron's accounting section 2. Create a manual invoice 3. In Transactions tab, you should see a 'Cancel charge' button. Click on it. It should now be marked as cancelled 4. Create another manual invoice 5. Pay it (partially or fully) 6. Notice that the 'Cancel charge' button is not available 7. Void the payment 8. 'Cancel charge' button is available again. Click on it and verify that it still works 9. prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 111791 [details] [review] Bug 24603: (follow-up) Update to double entry accounting This patch updates the logic to create a cancellation accountline and apply it to the charge line so we correction record the transaction in terms of double entry accounting standards. Test plan: 1. Go to a patron's accounting section 2. Create a manual invoice 3. In Transactions tab, you should see a 'Cancel charge' button. Click on it. It should now be marked as cancelled 4. A cancellation line should be associated with the original charge. 5. Create another manual invoice 6. Pay it (partially or fully) 7. Notice that the 'Cancel charge' button is not available 8. Void the payment 9. 'Cancel charge' button is available again. Click on it and verify that it still works 10. prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 111792 [details] [review] Bug 24603: Fix number of unit tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 111793 [details] [review] Bug 24603: (QA follow-up) Make the new credit type translatable and shorten description a bit Adding the new offset type and credit type to the include so it can be translated. Also suggest shortening the db description a bit. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Looks like the wrong bug report Katrin! :)
Yes - hopefully all fixed now!