Attachment 86382 [details] of bug introduces a typo in the letter code DUEDGST: - my $letter_type = 'DUEDGST'; + letter_code => 'DUEGST', This causes "Item Due Reminder (Digest)" messages not to be sent.
Hm, that should be bug 20478.
But 20478 is not in 18.11?
Created attachment 95532 [details] [review] Bug 24064 - DUEDGST typoed as DUEGST Bug 20478 introduced a typo where the letter code DUEDGST was changed to DUEGST. This patch fixes it. To test: - Run "grep -r DUEDGST *" on the Koha git repo. Notice that this letter code is used in e.g. sample notices. - Run "grep -r DUEGST *" and notice that this code only occurs twice, in misc/cronjobs/advance_notices.pl. - Aply this patch. - Run "grep -r DUEGST *" again, and notice there are no more occurences of this typo.
(In reply to Katrin Fischer from comment #2) > But 20478 is not in 18.11? No, Martin wrote: "Enhancement will not be backported to 18.11.x series." How so?
Ah, the version was set to 18.11? Dunno how that happened... Set it to master now.
Created attachment 95539 [details] [review] Bug 24064 - DUEDGST typoed as DUEGST Bug 20478 introduced a typo where the letter code DUEDGST was changed to DUEGST. This patch fixes it. To test: - Run "grep -r DUEDGST *" on the Koha git repo. Notice that this letter code is used in e.g. sample notices. - Run "grep -r DUEGST *" and notice that this code only occurs twice, in misc/cronjobs/advance_notices.pl. - Aply this patch. - Run "grep -r DUEGST *" again, and notice there are no more occurences of this typo. Signed-off-by: David Nind <david@davidnind.com>
Caused by commit e18626b6f142128064317e95ef4a7fb089f4f48d Bug 20478: Refactor to remove code duplication.
That sucks! What about the notices in the DB? :-/
(In reply to Jonathan Druart from comment #8) > What about the notices in the DB? :-/ letters or message_queue? None of them should be affected, except that since DUEGST is not found in letters, no DUE(D)GST messages will end up in message_queue.
Created attachment 95547 [details] [review] Bug 24064 - DUEDGST typoed as DUEGST Bug 20478 introduced a typo where the letter code DUEDGST was changed to DUEGST. This patch fixes it. To test: - Run "grep -r DUEDGST *" on the Koha git repo. Notice that this letter code is used in e.g. sample notices. - Run "grep -r DUEGST *" and notice that this code only occurs twice, in misc/cronjobs/advance_notices.pl. - Aply this patch. - Run "grep -r DUEGST *" again, and notice there are no more occurences of this typo. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work! Pushed to master for 19.11.00
backported to 19.05.x for 19.05.06