We have quite some templates where "Fees & Charges" appears. It should be "Fees & charges" instead.
Created attachment 102788 [details] [review] Bug 24098: Standardize Fines/Fees & Charges This patch suggests to adopt the terminology used in the OPAC to only use charges and leave off the Fines or Fees. To test: - Add a charge to your account - Check the note on the details and checkouts tabs - Check the tab name on the details tab - Activate batch checkouts via systempreferences for your patron category: - BatchCheckouts - BatchCheckoutsValidCategories - Add a guarantee to your patron and allow to see fines (requires: AllowStaffToSetFinesVisibilityForGuarantor) - Add a manual fine for the guaranee above NoIssuesChargeGuarantee - Go to the batch checkout tab of your patron and verify note there
Hi Katrin. A couple of other places text may need changing, or can be a separate bug: - Most of the messages changed also have 'fine balance' after, as part of the same message. Perhaps change to 'Checkouts are BLOCKED because their balance is OVER THE LIMIT.' - Where there are are no charges due on the accounting page, the message under the make a payment tab says '..has no outstanding fines.'. Change to '..has no outstanding charges.'. (Accounting > Make a payment tab) David
Created attachment 104513 [details] [review] Bug 24098: Standardize Fines/Fees & Charges This patch suggests to adopt the terminology used in the OPAC to only use charges and leave off the Fines or Fees. To test: - Add a charge to your account - Check the note on the details and checkouts tabs - Check the tab name on the details tab - Activate batch checkouts via systempreferences for your patron category: - BatchCheckouts - BatchCheckoutsValidCategories - Add a guarantee to your patron and allow to see fines (requires: AllowStaffToSetFinesVisibilityForGuarantor) - Add a manual fine for the guaranee above NoIssuesChargeGuarantee - Go to the batch checkout tab of your patron and verify note there Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to David Nind from comment #2) > Hi Katrin. > > A couple of other places text may need changing, or can be a separate bug: > > - Most of the messages changed also have 'fine balance' after, as part of > the same message. Perhaps change to 'Checkouts are BLOCKED because their > balance is OVER THE LIMIT.' > > - Where there are are no charges due on the accounting page, the message > under the make a payment tab says '..has no outstanding fines.'. Change to > '..has no outstanding charges.'. (Accounting > Make a payment tab) > > David Hi David, I think I might be dealing with these on a separate bug, if it's ok. I wonder if 'balance' will be understood without the fines part. Is there another phrasing we could think of?
(In reply to Katrin Fischer from comment #4) > Hi David, I think I might be dealing with these on a separate bug, if it's > ok. I wonder if 'balance' will be understood without the fines part. Is > there another phrasing we could think of? Another bug sounds fine to me! An alternative could be account balance or charges, rather than just balance. 'Checkouts are BLOCKED because fine balance is OVER THE LIMIT.' ==> 'Checkouts are BLOCKED because the account balance is OVER THE LIMIT.' or ==> 'Checkouts are BLOCKED because charges are OVER THE LIMIT.' .."has no outstanding fines.' ==> ..'has no outstanding account balance.' or ==> ..'has no outstanding charges.' (better I think, as the tab heading is now 'Charges'.
Created attachment 104560 [details] [review] Bug 24098: Standardize Fines/Fees & Charges This patch suggests to adopt the terminology used in the OPAC to only use charges and leave off the Fines or Fees. To test: - Add a charge to your account - Check the note on the details and checkouts tabs - Check the tab name on the details tab - Activate batch checkouts via systempreferences for your patron category: - BatchCheckouts - BatchCheckoutsValidCategories - Add a guarantee to your patron and allow to see fines (requires: AllowStaffToSetFinesVisibilityForGuarantor) - Add a manual fine for the guaranee above NoIssuesChargeGuarantee - Go to the batch checkout tab of your patron and verify note there Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to master for 20.05
not backported to 19.11.x