Bug 24100 - "Pay selected" is broken
Summary: "Pay selected" is broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: Main
Hardware: All All
: P5 - low critical
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on: 23788
Blocks:
  Show dependency tree / graph
 
Reported: 2019-11-24 20:39 UTC by Katrin Fischer
Modified: 2021-06-14 21:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Circulation function:

Attachments
Bug 24100: (bug 23788 follow-up) Capitalization correction (1.03 KB, patch)
2019-11-25 11:25 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 24100: (bug 23788 follow-up) Capitalization correction (1.09 KB, patch)
2019-11-25 14:09 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2019-11-24 20:39:58 UTC 
When using the "Pay selected" button to pay manual fees, I have the following error:

Can't locate object method "search" via package "koha::account::lines" (perhaps you forgot to load "koha::account::lines"?) at /home/vagrant/kohaclone/members/paycollect.pl line 146
Comment 1 Martin Renvoize (ashimema) 2019-11-25 11:18:48 UTC 
Not sure how `koha::account::lines` crept it.. when I QA'd the relevant bug it was `Koha::Account::Lines`.. perhaps a subsequent rebase.. 

Just testing a fix now.
Comment 2 Martin Renvoize (ashimema) 2019-11-25 11:25:27 UTC 
Created attachment 95779 [details] [review]
Bug 24100: (bug 23788 follow-up) Capitalization correction

Correct the capitalization of the class name introduced in bug 23788.

Test plan:
1) Prior to patch attempt to 'pay off selected' - Note a server error
2) Apply patch
3) Attempt to 'pay off selected' - Note it now works as expected.
4) Signoff
Comment 3 Tomás Cohen Arazi (tcohen) 2019-11-25 14:09:45 UTC 
Created attachment 95788 [details] [review]
Bug 24100: (bug 23788 follow-up) Capitalization correction

Correct the capitalization of the class name introduced in bug 23788.

Test plan:
1) Prior to patch attempt to 'pay off selected' - Note a server error
2) Apply patch
3) Attempt to 'pay off selected' - Note it now works as expected.
4) Signoff

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi (tcohen) 2019-11-25 14:10:44 UTC 
Trivial typo fix, skipping QA step.
Comment 5 Martin Renvoize (ashimema) 2019-11-25 17:03:58 UTC 
Nice work!

Pushed to master for 19.11.00