When a patron is created with a guarantor but a duplicate is found (or any other warnings I guess) the guarantor's info are lost. To recreate: Create a patron with surname=toto Create a kid with surname=toto and a guarantor Save Confirm that you want to create a new record => The guarantor info is not saved It works prior to bug 14570.
Created attachment 95834 [details] [review] Bug 24113: guarantor info lost when a duplicate is found When a patron is created with a guarantor but a duplicate is found (or any other warnings I guess) the guarantor's info are lost. This patch improves on previous functionality by retaining the select guarantor relationship as well. Test Plan: 1) Create a new child with a name already used, add a guarantor 2) Attempt to save, no the guarantor is not shown when the editor is redisplayed 3) Apply this patch 4) Restart all the things! 5) Repeat 1 6) Note the guarantor is retained and the relationship is as well!
Created attachment 95835 [details] [review] Bug 24113: guarantor info lost when a duplicate is found When a patron is created with a guarantor but a duplicate is found (or any other warnings I guess) the guarantor's info are lost. This patch improves on previous functionality by retaining the select guarantor relationship as well. Test Plan: 1) Create a new child with a name already used, add a guarantor 2) Attempt to save, no the guarantor is not shown when the editor is redisplayed 3) Apply this patch 4) Restart all the things! 5) Repeat 1 6) Note the guarantor is retained and the relationship is as well! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 95843 [details] [review] Bug 24113: guarantor info lost when a duplicate is found When a patron is created with a guarantor but a duplicate is found (or any other warnings I guess) the guarantor's info are lost. This patch improves on previous functionality by retaining the select guarantor relationship as well. Test Plan: 1) Create a new child with a name already used, add a guarantor 2) Attempt to save, no the guarantor is not shown when the editor is redisplayed 3) Apply this patch 4) Restart all the things! 5) Repeat 1 6) Note the guarantor is retained and the relationship is as well! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks for the quick fix, Passing QA and Pushing.
Nice work! Pushed to master for 19.11.00