After 19.11 the sorting icons for the search results disappeared. The search still works if you click on the header of the column, but the icons are gone. 19.05: https://paste.pics/8694b71e22504d77439b877166ca5e77 19.11: https://paste.pics/301f28373f9fc57756e401855fcb063b
Caused by bug 23013. cateditor-ui.inc is using .sorting_asc and .sorting_desc that were define in datatables.css Now the CSS definitions are more precise (table.dataTable thead .sorting_asc) and are no longer applied to the th.
Created attachment 96385 [details] [review] Bug 24169: Advanced editor: icons/buttons for sorting the search results are missing This patch "manually" adds the "dataTable" class to the table of search results in the advanced cataloging editor. This allows the correct styles to get picked up from existing CSS. To test, go to Cataloging and open the advanced editor. Perform a search using the sidebar search form. In the table of results, confirm that table sorting indicators look correct and that sorting works correctly.
Created attachment 96386 [details] [review] Bug 24169: Advanced editor: icons/buttons for sorting the search results are missing This patch "manually" adds the "dataTable" class to the table of search results in the advanced cataloging editor. This allows the correct styles to get picked up from existing CSS. To test, go to Cataloging and open the advanced editor. Perform a search using the sidebar search form. In the table of results, confirm that table sorting indicators look correct and that sorting works correctly. Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com>
Works great!
Owen, does not it sound more correct to copy the CSS definitions?
(In reply to Jonathan Druart from comment #5) > Owen, does not it sound more correct to copy the CSS definitions? It would be more correct, but I think the satisfaction of being technically correct would be outweighed by the effort. I think a pragmatic fix is better.
Created attachment 96469 [details] [review] Bug 24169: Advanced editor: icons/buttons for sorting the search results are missing This patch "manually" adds the "dataTable" class to the table of search results in the advanced cataloging editor. This allows the correct styles to get picked up from existing CSS. To test, go to Cataloging and open the advanced editor. Perform a search using the sidebar search form. In the table of results, confirm that table sorting indicators look correct and that sorting works correctly. Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 96470 [details] [review] Bug 24169: Add a comment to clarify the use of the dataTable class Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Owen Leonard from comment #6) > (In reply to Jonathan Druart from comment #5) > > Owen, does not it sound more correct to copy the CSS definitions? > > It would be more correct, but I think the satisfaction of being technically > correct would be outweighed by the effort. I think a pragmatic fix is better. It seemed easy to copy the 5 lines, and I was going to propose an alternative patch. But then I realised that we may also want the other .dataTable definitions as well. I guess that why you thought the effort was consequent, I did not think about that at first.
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.02
missing dependencies for 19.05.x, no backport