When using Itemfallbacksearch for checking out items without barcode, the checkboxes for automatic-renewal and on-site checkout are ignored. To test: - Turn on OnSiteCheckouts and Itemfallbacksearch - Open a patron account - Check the checkboxes for automatic-renewal and on-site checkout - Search for a title keyword in the checkout input box - Verify that the item checked out is not checked out as on-site and no auto-renewal flag was set
on-site checkout works for me.
Created attachment 96361 [details] [review] Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on OnSiteCheckouts and Itemfallbacksearch - Open a patron account - Check the checkboxes for automatic-renewal and on-site checkout - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression?
Created attachment 96362 [details] [review] Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on itemBarcodeFallbackSearch - Open a patron account - Check the checkboxes for automatic-renewal - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression?
Might be a version thing - thx Joubu!
This almost works perfectly, but there is one thing that is confusing: When there is a dialog (patron has some fines or more checked out than allowed override) the checkbox appears "unchecked", which is confusing. Could this be improved? Also tested in combination with OnSiteCheckoutAutoCheck.
Created attachment 96603 [details] [review] Bug 24171: Check auto_renew if confirmation is needed Test plan: Add some fines Check auto_renew and check an item out, using a title keyword Pick one item You get the confirmation box => Notice that the auto_renew checkbox is checked
Still not perfect, the "on-site checkout" is not disabled. But I would move that to its own bug report.
Created attachment 96726 [details] [review] Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on itemBarcodeFallbackSearch - Open a patron account - Check the checkboxes for automatic-renewal - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression? Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 96727 [details] [review] Bug 24171: Check auto_renew if confirmation is needed Test plan: Add some fines Check auto_renew and check an item out, using a title keyword Pick one item You get the confirmation box => Notice that the auto_renew checkbox is checked Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
In Firefox the option appears as disabled without the 'checked', but I think this is a browser issue and disabling it makes sense when you can't remove the option in that moment.
Created attachment 98254 [details] [review] Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on itemBarcodeFallbackSearch - Open a patron account - Check the checkboxes for automatic-renewal - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression? Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Created attachment 98255 [details] [review] Bug 24171: Check auto_renew if confirmation is needed Test plan: Add some fines Check auto_renew and check an item out, using a title keyword Pick one item You get the confirmation box => Notice that the auto_renew checkbox is checked Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.03