It would be beneficial to have a hook inside process_message_queue.pl to allow plugins the option of taking pre-processing actions on the messages in the message queue before they are sent. An example of where this would be beneficial is the Recalls plugin, where currently one has take serverside actions to configure additional cronjobs as part of setting the plugin up.
Created attachment 96048 [details] [review] Bug 24183: Add before_send_messages hook This patch adds a simple hook to the process_message_queue cronjob to allow plugins to pre-process messages in the messaging queue before they are sent.
Can you add a test plan for this?
I'd forgotten I'd written this.. but it's still just as relevant now.. Good question on requiring a test plan. Short of writing a plugin that utilizes it I'm really not sure how one can test this :( Ill try to come up with something.
Created attachment 102079 [details] [review] Bug 24183: Add before_send_messages hook This patch adds a simple hook to the process_message_queue cronjob to allow plugins to pre-process messages in the messaging queue before they are sent. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Trivial and safe plugin hook implementation following the existing standard paradigm. Passing QA directly.
I am ok with this - little nudges work sometimes!
Nice work everyone! Pushed to master for 20.05
Created attachment 103463 [details] [review] Bug 24183: (RM follow-up) Remove re-introduced UseKohaPlugins We removed UseKohaPlugins in bug 20415 but incidentally added a reference to it bug 24183. This patch corrects that error. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
feature not backported to 19.11.x
per request, backported to 19.11.x branch for 19.11.06
I've added documentation to https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks#Implemented_hooks - can you please check if it's correct?
Perfect, thanks Katrin.
New feature won't be backported to 19.05.x