This syspref was added in Bug 16149 and allows purchase suggestion notices to send via SMS if no email is present. As far as I know, the syspref only applies to purchase suggestion notices. The wording on the syspref is "(Disable/Enable) Send messages by SMS if no patron email is defined." Without the context gained by reading Bug 16149, this system preference very much suggest that it applies to *all* notices. I suggest changing this to "(Disable/Enable) Send purchase suggestion messages by SMS if no patron email is defined."
Whoops, but the wrong bug number in my description above. This syspref comes from bug 21241.
Created attachment 96053 [details] [review] Bug 24184: Reword FallbackToSMSIfNoEmail syspref text TEST PLAN: 1. Apply patch 2. Confirm new wording looks good.
Created attachment 96054 [details] [review] Bug 24184: Reword FallbackToSMSIfNoEmail syspref text Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 96057 [details] [review] Bug 24184: Reword FallbackToSMSIfNoEmail syspref text Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
We might consider renaming the pref here ?
Marcel, FallbackToSMSIfNoEmailForPurchaseSuggestions? Seems long.
(In reply to Lucas Gass from comment #6) > Marcel, > > FallbackToSMSIfNoEmailForPurchaseSuggestions? Seems long. Yeah. Too long.
I'm inclined to push this patch as-is and address the syspref name in a new bug when and if someone thinks of a good option.
(In reply to Andrew Fuerste-Henry from comment #8) > I'm inclined to push this patch as-is and address the syspref name in a new > bug when and if someone thinks of a good option. Yeah my idea too. Since it is in PQA now, the RM may do it..
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.02 joy
backported to 19.05.x for 19.05.07