24199 – t/Auth_with_shibboleth.t is failing randomly

Bug 24199 - t/Auth_with_shibboleth.t is failing randomly

Summary: t/Auth_with_shibboleth.t is failing randomly

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Test Suite (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P5 - low normal
Assignee:	Jonathan Druart
QA Contact:	Testopia

URL:
Keywords:

Depends on:	23042
Blocks:	25551
	Show dependency tree / graph

Reported:	2019-12-10 10:25 UTC by Jonathan Druart
Modified:	2020-11-30 21:47 UTC (History)
CC List:	4 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	20.05.00, 19.11.01, 19.05.06, 18.11.12
Circulation function:

Attachments
Bug 24199: (bug 23042 follow-up) Prevent t/Auth_with_shibboleth.t to fail randomly (1.24 KB, patch) 2019-12-10 10:26 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2019-12-10 10:25:01 UTC

#   at t/Auth_with_shibboleth.t line 140.
    #          got: 'https://testopac.com/Shibboleth.sso/Login?target=https://testopac.com/cgi-bin/koha/opac-user.pl%3Fparam%3D%22heh%E2%9D%A4%22%26language%3Den-GB'
    #     expected: 'https://testopac.com/Shibboleth.sso/Login?target=https://testopac.com/cgi-bin/koha/opac-user.pl%3Flanguage%3Den-GB%26param%3D%22heh%E2%9D%A4%22'


CGI->url_param does not always return the parameters in the same order.

Comment 1 Jonathan Druart 2019-12-10 10:26:47 UTC

Created attachment 96138 [details] [review]
Bug 24199: (bug 23042 follow-up) Prevent t/Auth_with_shibboleth.t to fail randomly

CGI->url_param does not always return the parameters in the same order.

Test plan:
0/ Recreate the random failure, does not apply the patch and run
t/Auth_with_shibboleth.t several times.
You will notice that it fails inconsistenly
1/ Apply the patch and confirm that it now passes 100% of the time

Comment 2 Martin Renvoize (ashimema) 2019-12-10 10:42:24 UTC

Thanks Jonathan.. that's the fix I was literally just testing locally as an RM followup.. Passing QA

Comment 3 Martin Renvoize (ashimema) 2019-12-10 10:43:49 UTC

Nice work everyone!

Pushed to master for 20.05

Comment 4 Joy Nelson 2019-12-16 21:41:27 UTC

Pushed to 19.11.01

Comment 5 Lucas Gass (lukeg) 2019-12-16 21:50:31 UTC

backported to 19.05.x for 19.05.06

Comment 6 Hayley Pelham 2019-12-17 01:16:01 UTC

Backported to 18.11.x for 18.11.12