Cannot recreate this one locally, it's failing on Koha_Master_D9_MDB_Latest (run 5) koha_1 | DBIC result _type isn't of the _type BiblioMetadata at /kohadevbox/koha/Koha/Patron.pm line 618. koha_1 | # Looks like your test exited with 11 just after 58. koha_1 | [15:56:22] t/db_dependent/Patron/Borrower_PrevCheckout.t Certainly a problem of missing data in tests. A guess, the following line should use build_sample_item: 248 my $item_d = $builder->build({source => 'Item'})
Got it again today on Koha_Master_D9_My8 (run 68)
Created attachment 97182 [details] [review] Bug 24200: Try to fix random failures from Borrower_PrevCheckout.t It failed inconsistently, let's try to use build_sample_item and see if it fixes the random failures. Test plan: % prove t/db_dependent/Patron/Borrower_PrevCheckout.t must return green
Sending to the QA queue.
Trivial fix, Passing QA and Pushing
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.03
Not fixed it seems :-/ Koha_Master_D8 (run 661) koha_1 | DBIC result _type isn't of the _type BiblioMetadata at /kohadevbox/koha/Koha/Patron.pm line 621. koha_1 | # Looks like your test exited with 255 just after 58. koha_1 | [12:01:25] t/db_dependent/Patron/Borrower_PrevCheckout.t ........................... koha_1 | Dubious, test returned 255 (wstat 65280, 0xff00) koha_1 | Failed 2/60 subtests
Reverted from 19.11.03 until fixed.
Appeared once again on Koha_Master_D8/759
Created attachment 100954 [details] [review] Bug 24200: (follow-up) Try to fix random failures from Borrower_PrevCheckout.t 2 other occurrences where missing.
Martin, can you push the second patch please?
Backported to 19.11.x for 19.11.05
backported to 19.05.x for 19.05.10
Minor patch will not be backported to 18.11.x series