URLs are not correct for the default values in the OPACSearchForTitleIn system peference: - Worldcat: now https - BookFinder: now https - OpenLibrary: URL search pattern changed These still work as the sites redirect to the https version, and the new URL pattern for the OpenLibrary.
> - Worldcat: now https > - BookFinder: now https I know we can update the installation SQL, but I'm assuming there's not a good way to update existing installations since the library could have customized this preference with their own options? > - OpenLibrary: URL search pattern changed The current pattern looks correct to me: https://openlibrary.org/search/?author=({AUTHOR})&title=({TITLE}) ...translates to: https://openlibrary.org/search?author=(Heinlein%2C%20Robert%20A.)&title=(Stranger%20in%20a%20strange%20land)
There is no / between search and the question mark for the query.
Created attachment 96569 [details] [review] Bug 24206: Update URLs for default options in OPACSearchForTitleIn - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify changes to the installer files are correct - Bonus: run the web installer for en, de-DE and nb-NO and verfiy the content of OPACSearchForTitleIn is correct
Created attachment 96570 [details] [review] Bug 24206: Update content of OpacSearchForTitleIn for existing installations This includes a database update for existing installations. Using the REPLACE function it makes the same changes to the URLs as the previous patch did for new installations: - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify the current content of your preference OpacSearchForTitleIn (without changes from first patch!) - Run the database update - Verify everything still works, but changes have been made
Thanks Katrin! This all works as expected. One minor point (and I'm not sure it needs updating), there is an extra space in installer/data/mysql/sysprefs.sql (line 426) between the a and href for the worldcat entry. This shows in the diff and when you click on 'Click to edit' in the staff interface. It doesn't affect it working though, and maybe I'm being too pedantic! Happy to sign-off either way.
Created attachment 96673 [details] [review] Bug 24206: Update URLs for default options in OPACSearchForTitleIn - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify changes to the installer files are correct - Bonus: run the web installer for en, de-DE and nb-NO and verfiy the content of OPACSearchForTitleIn is correct
Created attachment 96674 [details] [review] Bug 24206: Update content of OpacSearchForTitleIn for existing installations This includes a database update for existing installations. Using the REPLACE function it makes the same changes to the URLs as the previous patch did for new installations: - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify the current content of your preference OpacSearchForTitleIn (without changes from first patch!) - Run the database update - Verify everything still works, but changes have been made
Created attachment 96675 [details] [review] Bug 24206: Update content of OpacSearchForTitleIn for existing installations This includes a database update for existing installations. Using the REPLACE function it makes the same changes to the URLs as the previous patch did for new installations: - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify the current content of your preference OpacSearchForTitleIn (without changes from first patch!) - Run the database update - Verify everything still works, but changes have been made
(In reply to David Nind from comment #5) > Thanks Katrin! > > This all works as expected. > > One minor point (and I'm not sure it needs updating), there is an extra > space in installer/data/mysql/sysprefs.sql (line 426) between the a and href > for the worldcat entry. This shows in the diff and when you click on 'Click > to edit' in the staff interface. > > It doesn't affect it working though, and maybe I'm being too pedantic! > > Happy to sign-off either way. Hi David, the extra space was there before, but I will remove it now in my updated patch. I feel for you - I like things nice and clean as well :)
Thanks Katrin!
Created attachment 96768 [details] [review] Bug 24206: Update URLs for default options in OPACSearchForTitleIn - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify changes to the installer files are correct - Bonus: run the web installer for en, de-DE and nb-NO and verfiy the content of OPACSearchForTitleIn is correct Signed-off-by: David Nind <david@davidnind.com>
Created attachment 96769 [details] [review] Bug 24206: Update content of OpacSearchForTitleIn for existing installations This includes a database update for existing installations. Using the REPLACE function it makes the same changes to the URLs as the previous patch did for new installations: - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify the current content of your preference OpacSearchForTitleIn (without changes from first patch!) - Run the database update - Verify everything still works, but changes have been made Signed-off-by: David Nind <david@davidnind.com>
Thx David!
Created attachment 97186 [details] [review] Bug 24206: Update URLs for default options in OPACSearchForTitleIn - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify changes to the installer files are correct - Bonus: run the web installer for en, de-DE and nb-NO and verfiy the content of OPACSearchForTitleIn is correct Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 97187 [details] [review] Bug 24206: Update content of OpacSearchForTitleIn for existing installations This includes a database update for existing installations. Using the REPLACE function it makes the same changes to the URLs as the previous patch did for new installations: - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify the current content of your preference OpacSearchForTitleIn (without changes from first patch!) - Run the database update - Verify everything still works, but changes have been made Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Needs a small follow-up, bug number in updatedatabase is missing: Upgrade to 19.12.00.008 done (Bug XXXXX - Update OpacSearchForTitleIn system preference)
Created attachment 97264 [details] [review] Bug 24206: Add correct bug reference to update message in udpatedatabase Fixes a small oversight by changing XXXX to 24206.
Created attachment 97265 [details] [review] k
Comment on attachment 97265 [details] [review] k Wrong bug number!
Already pushed a followup :)
Pushed to 19.11.x branch for 19.11.03
backported to 19.05.x for 19.05.08
Patches will not be backported to 18.11.x series as no one should be installing 18.11.x.