Advanced notices DUEDGST does NOT send sms, just e-mail.
Function send_digests contains hard-coded value "advance_notice" in messge_name (line 552 of advance_notice.pl), but it should be passed-in as a parameter, because it's called for Advance_Notice as well as for Item_Due message attributes.
To reproduce this bug, please turn OFF sms PREDUEDGST, but have sms DUEDGST turned ON for a given borrower. Sms version of DUEDGST is never generated into the message queue.
Created attachment 96238 [details] [review] Bug 24235: Do not use hardcoded message_name Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed
Created attachment 96240 [details] [review] Bug 24235: Do not use hardcoded message_name Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed Signed-off-by: Michal Denar <black23@gmail.com>
Please add missing parameters to all 4 calls of "send_digests".
Are you sure about this patch? It sounds like a duplicate of bug 24072. I setup: https://snipboard.io/NfnZeG.jpg Then run advance_notices.pl Withtout this patch: MariaDB [koha_kohadev]> select * from message_queue\G *************************** 1. row *************************** message_id: 33 borrowernumber: 5 subject: Item Due Reminder content: You have 1 items due metadata: letter_code: DUEDGST message_transport_type: email status: pending time_queued: 2019-12-13 10:02:38 to_address: NULL from_address: root@localhost content_type: NULL *************************** 2. row *************************** message_id: 34 borrowernumber: 5 subject: duegst content: duedgst sms metadata: letter_code: DUEDGST message_transport_type: sms status: pending time_queued: 2019-12-13 10:02:38 to_address: NULL from_address: root@localhost content_type: NULL 2 rows in set (0.00 sec) With this patch: nothing is generated
Created attachment 96279 [details] [review] Bug 24235: DUEDGST not sent if PREDUDGST checkbox is off DUEDGST notice required PREDUEDGST to be on, but both messages have to be generated independently Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed
Jonathan, plase follow test plan: - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower On your screenshot is PREDUEDGST ON.
Created attachment 96283 [details] [review] Bug 24235: DUEDGST not sent if PREDUDGST checkbox is off DUEDGST notice required PREDUEDGST to be on, but both messages have to be generated independently Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 96308 [details] [review] Bug 24235: DUEDGST not sent if PREDUDGST checkbox is off DUEDGST notice required PREDUEDGST to be on, but both messages have to be generated independently Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.02
backported to 19.05.x for 19.05.07
Hi, Backporting this to 18.11.x resulted in conflicts which I don't know how to resolve. Can somebody please rebase for 18.11.x?