Currently the OPAC lists page doesn't require a login to access pages like the list-creation form. It would be a more seamless process for users if they were prompted to log in before reaching those forms.
Created attachment 96350 [details] [review] Bug 24249: OPAC lists page should require login for login-dependent operations This patch modifies opac-shelves.pl so that login is required if the requested operation is anything but "view" and "list." To test, apply the patch and go to the lists page in the OPAC while not logged in. - Click the "Log in to create a new list" link. - Log in. - You should be taken to the "Create a new list" form.
Hi Owen, I am not sure what the difference here is between before and after. I haven't been able to find a link to the 'add list' form, but only 'log in' links. Can you explain the change a bit more?
(In reply to Katrin Fischer from comment #2) > Hi Owen, I am not sure what the difference here is between before and after. > I haven't been able to find a link to the 'add list' form, but only 'log in' > links. Can you explain the change a bit more? ping?
Created attachment 97683 [details] [review] Bug 24249: OPAC lists page should require login for login-dependent operations This patch modifies opac-shelves.pl so that login is required if the requested operation is anything but "view" and "list." The patch also modifies a couple of "Log in to create a new list" links so that they point to the list creation form instead of opac-user.pl. To test, apply the patch and go to the main lists page (the list of lists) in the OPAC while not logged in. - Click the "Log in to create a new list" link. - Log in. - You should be taken to the "Create a new list" form. - Also test the "New list" link shown in the toolbar when you're viewing the contents of a list.
This works when you go 'Lists > Your lists > Log in to create a new list' (you end up at /cgi-bin/koha/opac-shelves.pl?op=add_form). However, when you go 'Lists > Log in to create your own lists' it goes to the your summary page (/cgi-bin/koha/opac-user.pl?has-search-query=). Also, logging in the via 'Lists > Your lists > Log in to create your own lists' comes up with a modal for your username and password, the other way it is an inline form. This is how it works now, but seems a little inconsistent. Probably another bug though...
I looked at the code and for 'Log in to create your own lists' is in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc, lines 73 and 75.
Created attachment 98824 [details] [review] Bug 24249: OPAC lists page should require login for login-dependent operations This patch modifies opac-shelves.pl so that login is required if the requested operation is anything but "view" and "list." The patch also modifies a couple of "Log in to create a new list" links so that they point to the list creation form instead of opac-user.pl. To test, apply the patch and go to the main lists page (the list of lists) in the OPAC while not logged in. - Click the "Log in to create a new list" link. - Log in. - You should be taken to the "Create a new list" form. - Also test the "New list" link shown in the toolbar when you're viewing the contents of a list. - When not logged in click the "Lists" menu in the page's header menu. Clicking "Log in to create a new list" should take you to the login form and then to the list creation form.
Created attachment 98886 [details] [review] Bug 24249: OPAC lists page should require login for login-dependent operations This patch modifies opac-shelves.pl so that login is required if the requested operation is anything but "view" and "list." The patch also modifies a couple of "Log in to create a new list" links so that they point to the list creation form instead of opac-user.pl. To test, apply the patch and go to the main lists page (the list of lists) in the OPAC while not logged in. - Click the "Log in to create your own lists" link. - Log in. - You should be taken to the "Create a new list" form. - Also test the "New list" link shown in the toolbar when you're viewing the contents of a list. - When not logged in click the "Lists" menu in the page's header menu. Clicking "Log in to create a new list" should take you to the login form and then to the list creation form. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 99132 [details] [review] Bug 24249: OPAC lists page should require login for login-dependent operations This patch modifies opac-shelves.pl so that login is required if the requested operation is anything but "view" and "list." The patch also modifies a couple of "Log in to create a new list" links so that they point to the list creation form instead of opac-user.pl. To test, apply the patch and go to the main lists page (the list of lists) in the OPAC while not logged in. - Click the "Log in to create a new list" link. - Log in. - You should be taken to the "Create a new list" form. - Also test the "New list" link shown in the toolbar when you're viewing the contents of a list. - When not logged in click the "Lists" menu in the page's header menu. Clicking "Log in to create a new list" should take you to the login form and then to the list creation form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Enhancement not backported to 19.11.x