Created attachment 96514 [details] [review] Bug 24283: (bug 21446 follow-up) close strong and add missing parens To Test: 1) Create a course in course reserves, make it inactive 2) Add an item to it, changing item type and location 3) Make the course enabled 4) Note that the normal item type is no longer bold and has both opening and closing parentheses; Note that the normal location is also not bold and has both opening and closing parentheses. 5) Disable the course 6) Note that the normal item type is in bold with an opening parentheses but no closing parentheses; Note that the normal location is in bold with both opening and closing parentheses. 7) Apply patch 8) Note view is fixed
Created attachment 96566 [details] [review] Bug 24283: (bug 21446 follow-up) close strong and add missing parens To Test: 1) Create a course in course reserves, make it inactive 2) Add an item to it, changing item type and location 3) Make the course enabled 4) Note that the normal item type is no longer bold and has both opening and closing parentheses; Note that the normal location is also not bold and has both opening and closing parentheses. 5) Disable the course 6) Note that the normal item type is in bold with an opening parentheses but no closing parentheses; Note that the normal location is in bold with both opening and closing parentheses. 7) Apply patch 8) Note view is fixed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.02
backported to 19.05.x for 19.05.07