To recreate: 0 - Set SearchEngine to Elasticsearch, QueryRegexEscapeOptions to 'Don't Escape' 1 - Browse to Authorities 2 - Select New->New from Z3950 3 - Search for subject 'Short stories' 4 - Auth search explodes
Created attachment 96524 [details] [review] Bug 24286: Escape forward slash in GENRE/FORM (and any authtype) Note that bug 24267 will fix the issue during Z39 searching for new auth, but the duplicate check at saving will still fail To test: 0 - Set SearchEngine to Elasticsearch, QueryRegexEscapeOptions to 'Don't Escape' 1 - Browse to Authorities 2 - Select New->New from Z3950 3 - Search for subject 'Short stories' 4 - Auth search explodes 5 - Apply patch 6 - Repeat and confirm the search results return 7 - Import and save the GENRE/FORM record for Short stories 8 - Repeat the search and import the same record 9 - Confirm that upon save you are notified of duplicate, don't save 10 - set QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works and importing/save notifies of duplicate 11 - set SearchEngine to Zebra and confirm Z39 searching works and importing/save notifies of duplicate
Please replace s/\//\\\// with s#/#\\/# to make it a bit more readable.
Created attachment 96765 [details] [review] Bug 24286: Escape forward slash in GENRE/FORM (and any authtype) Note that bug 24267 will fix the issue during Z39 searching for new auth, but the duplicate check at saving will still fail To test: 0 - Set SearchEngine to Elasticsearch, QueryRegexEscapeOptions to 'Don't Escape' 1 - Browse to Authorities 2 - Select New->New from Z3950 3 - Search for subject 'Short stories' 4 - Auth search explodes 5 - Apply patch 6 - Repeat and confirm the search results return 7 - Import and save the GENRE/FORM record for Short stories 8 - Repeat the search and import the same record 9 - Confirm that upon save you are notified of duplicate, don't save 10 - set QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works and importing/save notifies of duplicate 11 - set SearchEngine to Zebra and confirm Z39 searching works and importing/save notifies of duplicate
Created attachment 97543 [details] [review] Bug 24286: Escape forward slash in GENRE/FORM (and any authtype) Note that bug 24267 will fix the issue during Z39 searching for new auth, but the duplicate check at saving will still fail To test: 0 - Set SearchEngine to Elasticsearch, QueryRegexEscapeOptions to 'Don't Escape' 1 - Browse to Authorities 2 - Select New->New from Z3950 3 - Search for subject 'Short stories' 4 - Auth search explodes 5 - Apply patch 6 - Repeat and confirm the search results return 7 - Import and save the GENRE/FORM record for Short stories 8 - Repeat the search and import the same record 9 - Confirm that upon save you are notified of duplicate, don't save 10 - set QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works and importing/save notifies of duplicate 11 - set SearchEngine to Zebra and confirm Z39 searching works and importing/save notifies of duplicate Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Created attachment 97582 [details] [review] Bug 24286: Escape forward slash in GENRE/FORM (and any authtype) Note that bug 24267 will fix the issue during Z39 searching for new auth, but the duplicate check at saving will still fail To test: 0 - Set SearchEngine to Elasticsearch, QueryRegexEscapeOptions to 'Don't Escape' 1 - Browse to Authorities 2 - Select New->New from Z3950 3 - Search for subject 'Short stories' 4 - Auth search explodes 5 - Apply patch 6 - Repeat and confirm the search results return 7 - Import and save the GENRE/FORM record for Short stories 8 - Repeat the search and import the same record 9 - Confirm that upon save you are notified of duplicate, don't save 10 - set QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works and importing/save notifies of duplicate 11 - set SearchEngine to Zebra and confirm Z39 searching works and importing/save notifies of duplicate Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu>
Patch works as expected. Thank you!
Created attachment 97671 [details] [review] Bug 24286: Escape forward slash in GENRE/FORM (and any authtype) Note that bug 24267 will fix the issue during Z39 searching for new auth, but the duplicate check at saving will still fail To test: 0 - Set SearchEngine to Elasticsearch, QueryRegexEscapeOptions to 'Don't Escape' 1 - Browse to Authorities 2 - Select New->New from Z3950 3 - Search for subject 'Short stories' 4 - Auth search explodes 5 - Apply patch 6 - Repeat and confirm the search results return 7 - Import and save the GENRE/FORM record for Short stories 8 - Repeat the search and import the same record 9 - Confirm that upon save you are notified of duplicate, don't save 10 - set QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works and importing/save notifies of duplicate 11 - set SearchEngine to Zebra and confirm Z39 searching works and importing/save notifies of duplicate Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x for 19.11.03
19.05.x does not include QueryRegexEscapeOptions, no backport