Would be nice to be able to raise logging level and see errors from the indexer
Created attachment 96621 [details] [review] Bug 24306: Add debug switch to koha-indexer This raises the debug level a lot, it it a bit overwhelming, but may be useful in debugging indexing issues To test: 1 - Apply patches 2 - sudo koha-indexer --stop instance 3 - sudo debian/scripts/koha-indexer --start --debug instance 4 - tail -f /var/log/koha/instance/indexer-output.log 5 - Note you get a listing that nothign in the queue 6 - Go to staff client and make a change to a record 7 - Note the logs have tons of info
Created attachment 99460 [details] [review] Bug 24306: Add debug switch to koha-indexer This raises the debug level a lot, it it a bit overwhelming, but may be useful in debugging indexing issues To test: 1 - Apply patches 2 - sudo koha-indexer --stop instance 3 - sudo debian/scripts/koha-indexer --start --debug instance 4 - tail -f /var/log/koha/instance/indexer-output.log 5 - Note you get a listing that nothign in the queue 6 - Go to staff client and make a change to a record 7 - Note the logs have tons of info Signed-off-by: David Nind <david@davidnind.com>
Why --debug and not --verbose? Note that koha-elasticsearch has a verbose flag (and other script in debian/scripts) You should also update debian/docs/koha-indexer.xml, and maybe tell that the new flag is not for production use, bug debug purpose only (obvious if you keep --debug, but worth a note if we go with --verbose).
(In reply to Jonathan Druart from comment #3) > Why --debug and not --verbose? > Note that koha-elasticsearch has a verbose flag (and other script in > debian/scripts) > > You should also update debian/docs/koha-indexer.xml, and maybe tell that the > new flag is not for production use, bug debug purpose only (obvious if you > keep --debug, but worth a note if we go with --verbose). I think I went with debug because it is incredibly verbose. The script is hardcoded with verbose=1 in the options elsewhere, so you never really have a non-verbose option
Created attachment 107460 [details] [review] Bug 24306: (follow-up) Add documentation for debug option
Created attachment 108073 [details] [review] Bug 24306: Add debug switch to koha-indexer This raises the debug level a lot, it it a bit overwhelming, but may be useful in debugging indexing issues To test: 1 - Apply patches 2 - sudo koha-indexer --stop instance 3 - sudo debian/scripts/koha-indexer --start --debug instance 4 - tail -f /var/log/koha/instance/indexer-output.log 5 - Note you get a listing that nothign in the queue 6 - Go to staff client and make a change to a record 7 - Note the logs have tons of info Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 108074 [details] [review] Bug 24306: (follow-up) Add documentation for debug option Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 108075 [details] [review] Bug 24306: (QA follow-up) Fix the XML Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x