Bug 2431 - Bug with Comments Moderation when Editing
Summary: Bug with Comments Moderation when Editing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: rel_3_2
Hardware: PC All
: P3 major
Assignee: Chris Cormack
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-30 12:05 UTC by Nicole C. Engard
Modified: 2012-10-25 22:37 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
first comment and edited comment waiting (25.00 KB, image/png)
2008-07-30 12:05 UTC, Chris Cormack
Details
comment that is supposed to be in moderation showing on live (20.67 KB, image/png)
2008-07-30 12:06 UTC, Chris Cormack
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:51:06 UTC


---- Reported by nengard@gmail.com 2008-07-30 12:05:08 ----

When you enter a comment, it goes into moderation if moderation is turned on.  Then if the patron edits their comment it says that the new comment is pending moderation, but it's not in the moderation queue on the staff site and the new edited commented is live for the world to see.

Moderation works for first comments, but not edited comments - see screen shots.



---- Additional Comments From nengard@gmail.com 2008-07-30 12:05:51 ----

Created an attachment
first comment and edited comment waiting





---- Additional Comments From nengard@gmail.com 2008-07-30 12:06:22 ----

Created an attachment
comment that is supposed to be in moderation showing on live





---- Additional Comments From nengard@gmail.com 2008-08-06 05:06:10 ----

We may want to disable the ability to edit comments until this is fixed.



---- Additional Comments From jmf@liblime.com 2008-08-09 17:29:52 ----

moving this to 3.2



---- Additional Comments From gmcharlt@gmail.com 2008-08-13 07:09:56 ----

Assigning to Chris.



---- Additional Comments From chris@bigballofwax.co.nz 2009-05-13 00:58:08 ----

Looking into this one now



---- Additional Comments From chris@bigballofwax.co.nz 2009-05-13 01:13:45 ----

Testing on an update to date version from HEAD, comments edited appear to be going back into the moderation queue correctly, I am now checking the code to make doubly sure.



---- Additional Comments From chris@bigballofwax.co.nz 2009-05-13 01:21:26 ----

Yep the code looks right

"UPDATE reviews SET review=?,datereviewed=now(),approved=0





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:51 UTC  ---

This bug was previously known as _bug_ 2431 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2431
Imported an attachment (id=665)
Imported an attachment (id=666)

Actual time not defined. Setting to 0.0
The original submitter of attachment 665 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 666 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.