A broken XSLT file will just "silently" die and there are no longer any errors in the logs that can help to identify the problem. This used to work and must have changed somewhere sometime.
From commit 295ae33800a322facfdf56795f4c02b2fd53432b Bug 20272: Replace error numbers by codes in XSLT_Handler """ Make XSLT_Handler a little bit less noisy by defaulting print_warns to false unless $ENV{DEBUG} is set. (See also bug 19018). """ Marcel, I think we should warn the errors in the logs. They are not debug messages here, we should not rely on DEBUG. If too noisy we should fix the original issues, not hide all the errors (which make the XSLT debugging super hard)
Created attachment 96650 [details] [review] Bug 24313: Always display XSLT errors in logs From commit 295ae33800a322facfdf56795f4c02b2fd53432b Bug 20272: Replace error numbers by codes in XSLT_Handler """ Make XSLT_Handler a little bit less noisy by defaulting print_warns to false unless $ENV{DEBUG} is set. (See also bug 19018). """ I think we should warn the errors in the logs. They are not debug messages here, we should not rely on DEBUG. If too noisy we should fix the original issues, not hide all the errors (which make the XSLT debugging super hard) Test plan: Break a XSLT, reload the page and confirm that there are useful errors in the Koha log file
Created attachment 96654 [details] [review] Bug 24313: Always display XSLT errors in logs From commit 295ae33800a322facfdf56795f4c02b2fd53432b Bug 20272: Replace error numbers by codes in XSLT_Handler """ Make XSLT_Handler a little bit less noisy by defaulting print_warns to false unless $ENV{DEBUG} is set. (See also bug 19018). """ I think we should warn the errors in the logs. They are not debug messages here, we should not rely on DEBUG. If too noisy we should fix the original issues, not hide all the errors (which make the XSLT debugging super hard) Test plan: Break a XSLT, reload the page and confirm that there are useful errors in the Koha log file
Created attachment 97146 [details] [review] Bug 24313: Always display XSLT errors in logs From commit 295ae33800a322facfdf56795f4c02b2fd53432b Bug 20272: Replace error numbers by codes in XSLT_Handler """ Make XSLT_Handler a little bit less noisy by defaulting print_warns to false unless $ENV{DEBUG} is set. (See also bug 19018). """ I think we should warn the errors in the logs. They are not debug messages here, we should not rely on DEBUG. If too noisy we should fix the original issues, not hide all the errors (which make the XSLT debugging super hard) Test plan: Break a XSLT, reload the page and confirm that there are useful errors in the Koha log file Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.03
backported to 19.05.x for 19.05.08
Backported to 18.11.x for 18.11.14