Created attachment 96702 [details] Record causing silent failure Steps to reproduce: 0/Save the attachment "errorrecord.mrc" 1/Login to Koha with "EnableAdvancedCatalogingEditor" set to "Enable" 2/Go to Cataloging->AdvancedEditor 3/Click "Import Record" and navigate to the record saved from step 0 3.5/Verify that the "helpers" are active (green boxes around the control fields) -> if not go to Settings and click "Show helpers for fixed and coded fields" 4/Add an 003 with "blah" as the text (required for the default cataloging config) 5/Hit "Save to catalog" Results: The button spins and then returns to normal but the record is not saved to the catalog and no error message is displayed. Expected results: Error reporting an invalid 008 field If you click back to "Show fields verbatim" red dots will appear in the invalid 008 fields. This record was retrieved from public Z39.50 servers for a project.
Created attachment 96723 [details] [review] Bug 24323: Advanced editor - Invalid 008 with helper silently fails to save This patch adds a "else if" to fall through if the error message isn't one of the previously defined ones ("syntax" and "invalid") and presents the human with a generic message that "Something went wrong, cannot save." Prior to testing: a/Verify that Advanced Editor is enabled b/Download the errorrecord.mrc from bug To test: 1/Apply patch 2/Go to Cataloging->Advanced Editor 3/Click "Import Record" button and navigate to the record saved from step b/ 4/Add an 003 field (as required by the default cataloging config) 5/Hit "Save to catalog" 6/Verify that a message is passed to the user that the file was unable to be saved
assigning to me.
*** Bug 24196 has been marked as a duplicate of this bug. ***
*** Bug 24205 has been marked as a duplicate of this bug. ***
Created attachment 96771 [details] [review] Bug 24323: Advanced editor - Invalid 008 with helper silently fails to save This patch adds a "else if" to fall through if the error message isn't one of the previously defined ones ("syntax" and "invalid") and presents the human with a generic message that "Something went wrong, cannot save." Prior to testing: a/Verify that Advanced Editor is enabled b/Download the errorrecord.mrc from bug To test: 1/Apply patch 2/Go to Cataloging->Advanced Editor 3/Click "Import Record" button and navigate to the record saved from step b/ 4/Add an 003 field (as required by the default cataloging config) 5/Hit "Save to catalog" 6/Verify that a message is passed to the user that the file was unable to be saved Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I think it would be nice if the feedback would be more precise, highlighting the problem in the 008, but this is definitely a good step forward.
Created attachment 97166 [details] [review] Bug 24323: Advanced editor - Invalid 008 with helper silently fails to save This patch adds a "else if" to fall through if the error message isn't one of the previously defined ones ("syntax" and "invalid") and presents the human with a generic message that "Something went wrong, cannot save." Prior to testing: a/Verify that Advanced Editor is enabled b/Download the errorrecord.mrc from bug To test: 1/Apply patch 2/Go to Cataloging->Advanced Editor 3/Click "Import Record" button and navigate to the record saved from step b/ 4/Add an 003 field (as required by the default cataloging config) 5/Hit "Save to catalog" 6/Verify that a message is passed to the user that the file was unable to be saved Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 97167 [details] [review] Bug 24323: Advanced editor - Display an error message if the record did not save Invalid 008 with helper silently fails to save. This patch adds a "else if" to fall through if the error message isn't one of the previously defined ones ("syntax" and "invalid") and presents the human with a generic message that "Something went wrong, cannot save." Prior to testing: a/Verify that Advanced Editor is enabled b/Download the errorrecord.mrc from bug To test: 1/Apply patch 2/Go to Cataloging->Advanced Editor 3/Click "Import Record" button and navigate to the record saved from step b/ 4/Add an 003 field (as required by the default cataloging config) 5/Hit "Save to catalog" 6/Verify that a message is passed to the user that the file was unable to be saved Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.03
backported to 19.05.x for 19.05.08
Backported to 18.11.x for 18.11.14.