On checkout-notes.pl the Mark Seen and Mark Not Seen buttons at the top of the page remain greyed out when one selects notes from the list. To test: - turn on AllowCheckoutNotes - generate a checkout and a checkout note - go to /cgi-bin/koha/circ/checkout-notes.pl - click the checkbox for your note - verify that the Mark Seen button at the top of the screen remains grey and inoperable
Created attachment 96799 [details] [review] Bug 24335: Cannot mark checkout notes seen/not seen in bulk This patch changes the way checkbox events are handled on the checkout notes page so that checking a checkbox enables the batch operation controls. Note: The addition of a "markseen" class is a preventative measure to avoid future problems where using the "btn-small" class might not be specific enough. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Check any checkbox. The "Mark seen" and "Mark not seen" should go from disabled to enabled. - Test that the buttons work correctly. - Click the "Select all" and "Clear all" controls and confirm that the buttons are enabled and disabled correctly.
Created attachment 96800 [details] [review] Bug 24335: Cannot mark checkout notes seen/not seen in bulk This patch changes the way checkbox events are handled on the checkout notes page so that checking a checkbox enables the batch operation controls. Note: The addition of a "markseen" class is a preventative measure to avoid future problems where using the "btn-small" class might not be specific enough. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Check any checkbox. The "Mark seen" and "Mark not seen" should go from disabled to enabled. - Test that the buttons work correctly. - Click the "Select all" and "Clear all" controls and confirm that the buttons are enabled and disabled correctly. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Patch worked for me, thanks!
Created attachment 97172 [details] [review] Bug 24335: Cannot mark checkout notes seen/not seen in bulk This patch changes the way checkbox events are handled on the checkout notes page so that checking a checkbox enables the batch operation controls. Note: The addition of a "markseen" class is a preventative measure to avoid future problems where using the "btn-small" class might not be specific enough. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Check any checkbox. The "Mark seen" and "Mark not seen" should go from disabled to enabled. - Test that the buttons work correctly. - Click the "Select all" and "Clear all" controls and confirm that the buttons are enabled and disabled correctly. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.02
backported to 19.05.x for 19.05.07