The budget_lock is never set (and has never been): [% UNLESS lateorder.budget_lock %] <input type="submit" class="btn btn-default" value="Claim order" /> [% END %]
Created attachment 97125 [details] [review] Bug 24388: Remove uneeded test in lateorders.tt The budget_lock is never set (and has never been). Test plan: For QAer only, make sure this never worked
Hi Jonathan, can you rebase this patch? sing index info to reconstruct a base tree... M t/db_dependent/Koha/Acquisition/Basket.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Acquisition/Basket.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Acquisition/Basket.t error: Failed to merge in the changes. Patch failed at 0001 Bug 24161: Add tests
(In reply to Michal Denar from comment #2) > Hi Jonathan, > can you rebase this patch? > > sing index info to reconstruct a base tree... > M t/db_dependent/Koha/Acquisition/Basket.t > Falling back to patching base and 3-way merge... > Auto-merging t/db_dependent/Koha/Acquisition/Basket.t > CONFLICT (content): Merge conflict in > t/db_dependent/Koha/Acquisition/Basket.t > error: Failed to merge in the changes. > Patch failed at 0001 Bug 24161: Add tests This patch is at the top of a long dependency list.
Created attachment 98690 [details] [review] Bug 24388: Remove uneeded test in lateorders.tt The budget_lock is never set (and has never been). Test plan: For QAer only, make sure this never worked
Created attachment 99117 [details] [review] Bug 24388: Remove uneeded test in lateorders.tt The budget_lock is never set (and has never been). Test plan: For QAer only, make sure this never worked Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors. Variable budget_lock is not set in acqui/lateorders.pl
Created attachment 99131 [details] [review] Bug 24388: Remove uneeded test in lateorders.tt The budget_lock is never set (and has never been). Test plan: For QAer only, make sure this never worked Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors. Variable budget_lock is not set in acqui/lateorders.pl Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x for 19.11.04
backported to 19.05.x for 19.05.09