There is a space missing after "Adjustments plus shipping:" showing the amount directly after the text.
Created attachment 97263 [details] [review] Bug 24404: Add missing space on invoices page / remove . from status On the bottom of the invoices page the summary of adjustments and shipping shows as: Adjustments plus shipping:2.00 The patch adds the missing space between text and amount. To test: - 'Receive shipment' from a result in your vendor search - Start a new invoice by entering an invoice number, amount for shipping cost and fund. - Finish receive (you don't need to receive anything) - You should now be on invoice.pl - Verify Status is 'Open.' and in 'Invoice details' we have the amount with the missing space. - Apply patch, reload the page. - Verify the missing space is there and the . is gone. - Close invoice, no . there either.
Created attachment 97348 [details] [review] Bug 24404: Add missing space on invoices page / remove . from status On the bottom of the invoices page the summary of adjustments and shipping shows as: Adjustments plus shipping:2.00 The patch adds the missing space between text and amount. To test: - 'Receive shipment' from a result in your vendor search - Start a new invoice by entering an invoice number, amount for shipping cost and fund. - Finish receive (you don't need to receive anything) - You should now be on invoice.pl - Verify Status is 'Open.' and in 'Invoice details' we have the amount with the missing space. - Apply patch, reload the page. - Verify the missing space is there and the . is gone. - Close invoice, no . there either. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 97478 [details] [review] Bug 24404: Add missing space on invoices page / remove . from status On the bottom of the invoices page the summary of adjustments and shipping shows as: Adjustments plus shipping:2.00 The patch adds the missing space between text and amount. To test: - 'Receive shipment' from a result in your vendor search - Start a new invoice by entering an invoice number, amount for shipping cost and fund. - Finish receive (you don't need to receive anything) - You should now be on invoice.pl - Verify Status is 'Open.' and in 'Invoice details' we have the amount with the missing space. - Apply patch, reload the page. - Verify the missing space is there and the . is gone. - Close invoice, no . there either. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.03
backported to 19.05.x for 19.05.08
Enhancement will not be backported to 18.11.x series.
(In reply to Hayley Mapley from comment #7) > Enhancement will not be backported to 18.11.x series. Really just a typo fix (adds one space) - but causes a string change.
Yeah, I should have specified because of string change sorry! It's on my list for review for next minor point release :)
Thx Hayley!