A small thing I've been wondering about: The links in the facets are shown underlined, but other links, like the links on each search result (title, place holds etc.) or navigation bar are not. Why are some links underlined and others not? There is a specific style causing this: #search-facets a { font-weight: 400; text-decoration: underline; }
Created attachment 104598 [details] [review] Bug 24405: Make OPAC link underlining consistent This patch makes a minor modification to the OPAC CSS so that links are consistently displayed without underlines in their inactive state. This corrects two cases: Links in the facets sidebar and "Check all/none" links shown on search results. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the OPAC, perform a search. - In the search results facets sidebar, confirm that links are not underlined. - At the top of the search results table, confirm that the "Select all" and "Clear all" links are not underlined.
Created attachment 104628 [details] [review] Bug 24405: Make OPAC link underlining consistent This patch makes a minor modification to the OPAC CSS so that links are consistently displayed without underlines in their inactive state. This corrects two cases: Links in the facets sidebar and "Check all/none" links shown on search results. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the OPAC, perform a search. - In the search results facets sidebar, confirm that links are not underlined. - At the top of the search results table, confirm that the "Select all" and "Clear all" links are not underlined. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 105759 [details] [review] Bug 24405: Make OPAC link underlining consistent This patch makes a minor modification to the OPAC CSS so that links are consistently displayed without underlines in their inactive state. This corrects two cases: Links in the facets sidebar and "Check all/none" links shown on search results. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the OPAC, perform a search. - In the search results facets sidebar, confirm that links are not underlined. - At the top of the search results table, confirm that the "Select all" and "Clear all" links are not underlined. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial patch, works as expected, no obvious side effects. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
enhancement, not backported to 19.11.x