Part of the POD for this subroutine looks like this: 42 my $preferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $borrower->{'borrowernumber'}, 43 message_name => 'DUE' } ); 44 45 my $preferences = C4::Members::Messaging::GetMessagingPreferences( { categorycode => 'LIBRARY', 46 message_name => 'DUE' } ); It looks like the value for message_name should be a value from letter.code, but it should be a name from message_attributes.message_name: 75 AND message_transports.is_digest = borrower_message_preferences.wants_digest 76 WHERE message_attributes.message_name = ? 77 END_SQL 78 79 my @bind_params = ( $params->{'message_name'} ); Note: This subroutine is set to be renamed and moved by Bug 18595, but the POD seems to be untouched there.
Created attachment 115484 [details] [review] Bug 24447: Changing 'DUE' to example in database that exists. Test Plan: 1.Using perldoc C4/Members/Messaging.pm check that message_name attribute name example is Item_Due and not DUE.
Created attachment 115603 [details] [review] Bug 24447: Changing 'DUE' to example in database that exists. Test Plan: 1.Using perldoc C4/Members/Messaging.pm check that message_name attribute name example is Item_Due and not DUE. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice one, thx Eden!
Created attachment 115606 [details] [review] Bug 24447: Changing 'DUE' to example in database that exists. Test Plan: 1.Using perldoc C4/Members/Messaging.pm check that message_name attribute name example is Item_Due and not DUE. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Backported: Pushed to 19.11.x branch for 19.11.15