The script takes a specific column to use as the to email address, however, due to variable confusion, the column is not respected
Created attachment 97884 [details] [review] Bug 24511: Update variable names to avoid confusion To test: 1 - Create a report SELECT borrowernumber, firstname, surname, email, emailpro FROM borrowers WHERE surname='acosta' 2 - Create or edit patron with surname acosta to have a separate email and emailpro 3 - perl misc/cronjobs/patron_emailer --notice HOLDS --module reserves --verbose --email emailpro --report ## --from 'me@you.us' 4 - Note email is used, not email pro 5 - Apply patch 6 - Repeat, correct eamil is used
Created attachment 97892 [details] [review] Bug 24511: Update variable names to avoid confusion To test: 1 - Create a report SELECT borrowernumber, firstname, surname, email, emailpro FROM borrowers WHERE surname='acosta' 2 - Create or edit patron with surname acosta to have a separate email and emailpro 3 - perl misc/cronjobs/patron_emailer --notice HOLDS --module reserves --verbose --email emailpro --report ## --from 'me@you.us' 4 - Note email is used, not email pro 5 - Apply patch 6 - Repeat, correct eamil is used Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
The line should be this : perl misc/cronjobs/patron_emailer.pl --notice HOLD --module reserves --verbose --email emailpro --report ## --from 'me@you.us' but it did work as expected. It used the emailpro email when running this cron line.
Created attachment 97942 [details] [review] Bug 24511: Update variable names to avoid confusion To test: 1 - Create a report SELECT borrowernumber, firstname, surname, email, emailpro FROM borrowers WHERE surname='acosta' 2 - Create or edit patron with surname acosta to have a separate email and emailpro 3 - perl misc/cronjobs/patron_emailer --notice HOLDS --module reserves --verbose --email emailpro --report ## --from 'me@you.us' 4 - Note email is used, not email pro 5 - Apply patch 6 - Repeat, correct eamil is used Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x for 19.11.03
backported to 19.05.x for 19.05.08
Dependency (script patron_emailer) not present in 18.11, so will not be backported to 18.11.x series.