ON the opac-password-recovery page the paragraph "To reset your password, enter your login or your email address." is missing a closing </p>. This is trivial but it does make it nearly impossible to update or hide that element with jQuery as it will effect the entire form below it.
Created attachment 98007 [details] [review] Bug 24523: add missing </p> TEST PLAN: 1. Add this jQuery to OPACUserJS ( $('p:contains("To reset your password, enter your login or your email address.")').text('I want to change this text'); ) 2. Reload the opac-password-recovery page. 3. The text is changed but the rest of the form is now gone 4. Apply patch and reload the opac-password-recovery page. 5. Reload the page and the text should be changed but the form should be there!
Created attachment 98008 [details] [review] Bug 24523: add missing </p> Signed-off-by: David Roberts <david.roberts@ptfs-europe.com>
Works OK as per test, as long as the OpacResetPassword system preference is also enabled.
Created attachment 98209 [details] [review] Bug 24523: add missing </p> Signed-off-by: David Roberts <david.roberts@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=24532
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.03
backported to 19.05.x for 19.05.08