On the OPAC, the dropdown for Lists always includes the heading Public Lists, even if no public lists exist. This is sub-optimal for libraries that want VirtualShelves enabled for private lists but don't want to use public lists. Could we just make the heading not show if there are no public lists in the system?
Andrew,
Created attachment 98259 [details] [review] Bug 24560: Dont show Public lists if there are 0 TEST PLAN: 1. have no public list and look at the List dropdown on the OPAC. It says No Public Lists. 2. Apply patch 3. It should now not say anything about public lists but still be formatted nice. 4. Add some public lists and confirm that everything looks normal. 5. Sign off
Created attachment 98260 [details] [review] Bug 24560: Dont show Public lists if there are 0 Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Created attachment 98264 [details] [review] Bug 24560: Dont show No Public Lists in OPAC Offering a better patch. Test plan remains the same. TEST PLAN: 1. have no public list and look at the List dropdown on the OPAC. It says No Public Lists. 2. Apply patch 3. It should now not say anything about public lists but still be formatted nice. 4. Add some public lists and confirm that everything looks normal. 5. Sign off
Created attachment 98265 [details] [review] Bug 24560: Remove No public list text from OPAC TEST PLAN: 1. have no public list and look at the List dropdown on the OPAC. It says No Public Lists. 2. Apply patch 3. It should now not say anything about public lists but still be formatted nice. 4. Add some public lists and confirm that everything looks normal. 5. Sign off
Created attachment 98350 [details] [review] Bug 24560: Remove No public list text from OPAC Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 98362 [details] [review] Bug 24560: Remove No public list text from OPAC On the OPAC, the dropdown for Lists always includes the heading Public Lists, even if no public lists exist. This is sub-optimal for libraries that want VirtualShelves enabled for private lists but don't want to use public lists. TEST PLAN: 1. have no public list and look at the List dropdown on the OPAC. It says No Public Lists. 2. Apply patch 3. It should now not say anything about public lists but still be formatted nice. 4. Add some public lists and confirm that everything looks normal. 5. Sign off Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Hi Lucas, please make sure that you include a description of the problem and a test plan in your commit messages - I've fixed it this time around :)
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.03
enhancement, not backporting to 19.05.x