When an item that has triggered a hold is in transit to a library, if the item is accidently shelved instead of scanned at the pickup library, and then checked out to another patron, the holds shows the item still in transit in the status, but says that it is waiting at the library, and the since date has vanished! To replicate: 1) Place an item on hold at Library A for Patron 1 at Library B. 2) Check in the item at Library A to trigger the hold transfer. 3) At Library B, check out the item to Patron 2 (click Yes). * Note that the hold still show in transit in the status. * Note that the Pickup library shows the item is waiting. * Note that the since date in the Pickup library is blank. What needs to happen: If an item is intercepted and checked out to a patron while in transit: * The transfer needs to be cancelled. * The hold needs to revert back to the top of the queue.
This reads a bit similar to bug 11722, could these be duplicates?
(In reply to Katrin Fischer from comment #1) > This reads a bit similar to bug 11722, could these be duplicates? Not sure. That was 6 years ago. This gives a better explanation, if it is.
Created attachment 108002 [details] [review] Bug 24598: Add tests
Created attachment 108003 [details] [review] Bug 24598: Complete transfer for hold if checked out When an item that has triggered a hold is in transit to a library, if the item is accidently shelved instead of scanned at the pickup library, and then checked out to another patron, the holds shows the item still in transit in the status, but says that it is waiting at the library, and the since date has vanished! Test plan: 1) Place an item on hold at Library A for Patron 1 at Library B 2) Check in the item at Library A to trigger the hold transfer 3) At Library B, check out the item to Patron 2 (click Yes) => The hold is not marked as in transit and is back to priority 1
Created attachment 110889 [details] [review] Bug 24598: Add tests Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Created attachment 110890 [details] [review] Bug 24598: Complete transfer for hold if checked out When an item that has triggered a hold is in transit to a library, if the item is accidently shelved instead of scanned at the pickup library, and then checked out to another patron, the holds shows the item still in transit in the status, but says that it is waiting at the library, and the since date has vanished! Test plan: 1) Place an item at Library A on hold for Patron 1 of Library B with pickup library at Library B 2) Check in the item at Library A to trigger the hold transfer 3) At Library B, check out the item to Patron 2 (click Yes) => The hold is not marked as in transit and is back to priority 1 Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Nice work. Test plan and unit test are OK. I add to rebase a bit unit test patch. Also changed a bit the test plan : - 1) Place an item on hold at Library A for Patron 1 at Library B + 1) Place an item at Library A on hold for Patron 1 of Library B with pickup library at Library B Because I forgot twice to change pickup library ;)
QAing
Created attachment 111060 [details] [review] Bug 24598: Add tests Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] 49 to 50 tests.
Created attachment 111061 [details] [review] Bug 24598: Complete transfer for hold if checked out When an item that has triggered a hold is in transit to a library, if the item is accidently shelved instead of scanned at the pickup library, and then checked out to another patron, the holds shows the item still in transit in the status, but says that it is waiting at the library, and the since date has vanished! Test plan: 1) Place an item at Library A on hold for Patron 1 of Library B with pickup library at Library B 2) Check in the item at Library A to trigger the hold transfer 3) At Library B, check out the item to Patron 2 (click Yes) => The hold is not marked as in transit and is back to priority 1 Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 20.11, thanks to everybody involved!
Created attachment 111371 [details] [review] Bug 24598: Remove warning from test t/db_dependent/Koha/Items.t .. 6/12 Use of uninitialized value in string eq at /kohadevbox/koha/C4/Circulation.pm line 1460.
(In reply to Jonathan Druart from comment #12) > Created attachment 111371 [details] [review] [review] > Bug 24598: Remove warning from test > > t/db_dependent/Koha/Items.t .. 6/12 Use of uninitialized value in string eq > at /kohadevbox/koha/C4/Circulation.pm line 1460. Patch pushed to master.
does not apply cleanly to 20.05.x, no backport please rebase if needed