Missed one on bug 14716
Created attachment 98539 [details] [review] Bug 24605: Fix unencoded series link To test: 1 - Add an 830 to a record with a volume subfield separated by a semicolon 830$aThe series ;$vvol 8. 2 - View the record in the opac 3 - Click the series link, no results 4 - View the link url - the semicolon is not encoded 5 - Apply patch 6 - link works 7 - URL is corrrectly encoded
Hi, What kind of record is needed? I edited a record to add an 830 field, does not show in the opac.
Hi Bernardo, you also need a 490 where the indicator is set to traced.
Created attachment 99509 [details] [review] Bug 24605: Fix unencoded series link To test: 1 - Add an 830 to a record with a volume subfield separated by a semicolon 830$aThe series ;$vvol 8. 2 - View the record in the opac 3 - Click the series link, no results 4 - View the link url - the semicolon is not encoded 5 - Apply patch 6 - link works 7 - URL is corrrectly encoded Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99553 [details] [review] Bug 24605: (QA follow-up) Fix unencoded series link in staff interface Same change as the first patch, but for the staff detail page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This was only half the fix - please remember OPAC and staff use different XSLT files.
(In reply to Katrin Fischer from comment #3) > Hi Bernardo, you also need a 490 where the indicator is set to traced. Thanks Katrin, I don't know much about MARC, but wanted to test. Questions: * Why we still hide 490 in our frameworks for new installs? * Wouldn't it be better to make both 440 'and' 490 visible?
(In reply to Bernardo Gonzalez Kriegel from comment #7) > (In reply to Katrin Fischer from comment #3) > > Hi Bernardo, you also need a 490 where the indicator is set to traced. > > Thanks Katrin, I don't know much about MARC, but wanted to test. > > Questions: > * Why we still hide 490 in our frameworks for new installs? > * Wouldn't it be better to make both 440 'and' 490 visible? Hi Bernardo, you are right: 440 has been succeeded by 490. It would make sense to change the default for new installations to hide 440 and display 490 instead. Or display both (assuming some data still uses 440, although it's been obsoleted) But better on a separate bug - I think there might even be one already somewhere.
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x branch for 19.11.05
backported to 19.05.x for 19.05.10