Bug 24630 - UNIMARC XSLT Update for bug 7611
Summary: UNIMARC XSLT Update for bug 7611
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on: 7611
Blocks:
  Show dependency treegraph
 
Reported: 2020-02-11 14:18 UTC by Nick Clemens
Modified: 2023-06-08 22:26 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00


Attachments
Bug 24630: UNIMARC XSLT changes for bug 7611 (11.74 KB, patch)
2020-02-11 14:19 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24630: UNIMARC XSLT changes for bug 7611 (11.75 KB, patch)
2020-07-28 12:04 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24630: UNIMARC XSLT changes for bug 7611 (11.81 KB, patch)
2021-02-09 14:52 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 24630: (follow-up 1) fix indenting (4.23 KB, patch)
2021-02-09 14:52 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 24630: (follow-up 2) call number when singleBranchMode=1 (2.54 KB, patch)
2021-02-09 14:53 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 24630: (follow-up 2) call number when singleBranchMode=1 (2.60 KB, patch)
2021-12-30 16:38 UTC, Florian
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2020-02-11 14:18:02 UTC
Add some classes and display authorized values for notforloan statuses based on work from bug 7611
Comment 1 Nick Clemens 2020-02-11 14:19:22 UTC
Created attachment 98709 [details] [review]
Bug 24630: UNIMARC XSLT changes for bug 7611

Follow test plan from 7611 on a UNIMARC system.

These changes have not been tested by me
Comment 2 Nick Clemens 2020-07-28 12:04:00 UTC
Created attachment 107462 [details] [review]
Bug 24630: UNIMARC XSLT changes for bug 7611

Follow test plan from 7611 on a UNIMARC system.

These changes have not been tested by me
Comment 3 Fridolin Somers 2020-09-29 15:09:24 UTC
I start testing, looks good
Comment 4 Fridolin Somers 2021-02-09 14:28:25 UTC
I see it adds callnumber with classes like in MARC21 :
  <span class="CallNumberAndLabel">
    <span class="LabelCallNumber">Call number: </span>
    <span class="CallNumber"><xsl:value-of select="items:itemcallnumber"/></span>
  </span>

This is really great for styling.

But I see [] are added by CSS :

.ItemSummary .LabelCallNumber:before {
 content:" ["
}
.ItemSummary .CallNumber:after {
 content:"]"
}

In this case [ disappears if you hide LabelCallNumber.

Shouldn't it be :

.ItemSummary .CallNumberAndLabel:before {
 content:" ["
}
.ItemSummary .CallNumberAndLabel:after {
 content:"]"
}

I'll create another bug report it confirmed.
Comment 5 Fridolin Somers 2021-02-09 14:52:16 UTC
Created attachment 116578 [details] [review]
Bug 24630: UNIMARC XSLT changes for bug 7611

Follow test plan from 7611 on a UNIMARC system.

These changes have not been tested by me

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Comment 6 Fridolin Somers 2021-02-09 14:52:50 UTC
Created attachment 116579 [details] [review]
Bug 24630: (follow-up 1) fix indenting
Comment 7 Fridolin Somers 2021-02-09 14:53:04 UTC
Created attachment 116580 [details] [review]
Bug 24630: (follow-up 2) call number when singleBranchMode=1

singleBranchMode=1 is when there is only one library (branch).

Test disply of available item.
Patch allows display of call number like in regular mode
Comment 8 Fridolin Somers 2021-02-09 14:54:18 UTC
I've signed main patch and added 2 followups
Comment 9 Florian 2021-12-30 16:38:12 UTC
Created attachment 128935 [details] [review]
Bug 24630: (follow-up 2) call number when singleBranchMode=1

singleBranchMode=1 is when there is only one library (branch).

Test disply of available item.
Patch allows display of call number like in regular mode

Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com>
Comment 10 Jonathan Druart 2022-02-08 17:51:57 UTC
No UNIMARC user in the QA team, trusting author and testers.
Comment 11 Fridolin Somers 2022-02-15 07:42:05 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄