When you go in Adminitration > Budgets > (Budget) > Planning > Plan by ... (aqplan.pl), the terms for MONTHS, BRANCHES and ITEMTYPES are not translatable. To reproduce: 1. Install another language if you don't already have one 2. Go to Administration > Budgets 3. Click on a budget (or create one if you don't already have one) 4. Click on Planning and choose one of the options (for example Plan by months) 5. Notice at the top it says 'Planning for <budget name> by MONTHS' 6. Switch languages 7. Notice 'MONTHS' is still in English I looked in my fr-CA-staff-prog.po file and 'MONTHS' is not in there (even after an update). I know it's been like this for several versions, but I can't find a bug report for this. Sorry if it is a duplicate.
Created attachment 103893 [details] [review] Bug 24636: translate planning sections This patch adds a new inc file to process and translate plannig sections To test: 1) Apply patch 2) Create new language files (cd misc/translator; ./translate create xx-YY) 3) Verify new file is taken into account in translation files egrep -n budget_planning misc/translator/xx-YY*.po check new strings in staff-prog file 4) Go to Administration > Budgets > Founds > Planning select different options, check page title and 'Planning for...' phrase 5) Translate strings, install new language, enable it, verify the text change with options like point 4)
Created attachment 103952 [details] [review] Bug 24636: translate planning sections This patch adds a new inc file to process and translate plannig sections To test: 1) Apply patch 2) Create new language files (cd misc/translator; ./translate create xx-YY) 3) Verify new file is taken into account in translation files egrep -n budget_planning misc/translator/xx-YY*.po check new strings in staff-prog file 4) Go to Administration > Budgets > Founds > Planning select different options, check page title and 'Planning for...' phrase 5) Translate strings, install new language, enable it, verify the text change with options like point 4) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I'll pass this, but wonder if it would be better to include the 'by' in the include. by months = nach Monaten months = Monate The translation changes at least in German because of declination.
Created attachment 104142 [details] [review] Bug 24636: translate planning sections This patch adds a new inc file to process and translate plannig sections To test: 1) Apply patch 2) Create new language files (cd misc/translator; ./translate create xx-YY) 3) Verify new file is taken into account in translation files egrep -n budget_planning misc/translator/xx-YY*.po check new strings in staff-prog file 4) Go to Administration > Budgets > Founds > Planning select different options, check page title and 'Planning for...' phrase 5) Translate strings, install new language, enable it, verify the text change with options like point 4) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #3) > I'll pass this, but wonder if it would be better to include the 'by' in the > include. > > by months = nach Monaten > months = Monate > > The translation changes at least in German because of declination. No problem to write an alternative patch.
Created attachment 104241 [details] [review] Bug 24636: follow-up - move 'by' into include file To ease correct translation.
(In reply to Katrin Fischer from comment #3) > I'll pass this, but wonder if it would be better to include the 'by' in the > include. > > by months = nach Monaten > months = Monate > > The translation changes at least in German because of declination. Added follow-up, possible target of your super-powers :) or switch to NSO
Created attachment 104242 [details] [review] Bug 24636: (follow-up) - move 'by' into include file To ease correct translation. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx for the follow-up! :)
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.06