There is something wrong between the logic in Koha::Cache->new and our dependencies. We are having Cache::Memcached required, but Cache::Memcached::Fast::Safe is optional. However, in Koha::Cache->new we are initializing the Memcached cache only if Cache::Memcached::Fast::Safe is installed. We could fix the logic in Koha::Cache, but it seems better to make Cache::Memcached::Fast::Safe mandatory (especially after bug 13193). Note that after bug 13193, you are loosing the Memcached cache, as Cache::Memcached::Fast::Safe will not get installed by default.
Created attachment 98755 [details] [review] Bug 24642: Make Cache::Memcached::Fast::Safe required There is something wrong between the logic in Koha::Cache->new and our dependencies. We are having Cache::Memcached required, but Cache::Memcached::Fast::Safe is optional. However, in Koha::Cache->new we are initializing the Memcached cache only if Cache::Memcached::Fast::Safe is installed. We could fix the logic in Koha::Cache, but it seems better to make Cache::Memcached::Fast::Safe mandatory (especially after bug 13193). Note that after bug 13193, you are loosing the Memcached cache, as Cache::Memcached::Fast::Safe will not get installed by default.
Created attachment 98756 [details] [review] Bug 24642: Make Cache::Memcached::Fast::Safe required There is something wrong between the logic in Koha::Cache->new and our dependencies. We are having Cache::Memcached required, but Cache::Memcached::Fast::Safe is optional. However, in Koha::Cache->new we are initializing the Memcached cache only if Cache::Memcached::Fast::Safe is installed. We could fix the logic in Koha::Cache, but it seems better to make Cache::Memcached::Fast::Safe mandatory (especially after bug 13193). Note that after bug 13193, you are loosing the Memcached cache, as Cache::Memcached::Fast::Safe will not get installed by default. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 98761 [details] [review] Bug 24642: Make Cache::Memcached::Fast::Safe required There is something wrong between the logic in Koha::Cache->new and our dependencies. We are having Cache::Memcached required, but Cache::Memcached::Fast::Safe is optional. However, in Koha::Cache->new we are initializing the Memcached cache only if Cache::Memcached::Fast::Safe is installed. We could fix the logic in Koha::Cache, but it seems better to make Cache::Memcached::Fast::Safe mandatory (especially after bug 13193). Note that after bug 13193, you are loosing the Memcached cache, as Cache::Memcached::Fast::Safe will not get installed by default. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice work everyone! Pushed to master for 20.05
Should we add a dependency reference here for Cache::Memcached::Fast::Safe ? Strange that it is not even mentioned anywhere on the report..
enhancement - not pushed to 19.11.x (see notes on 13193)
Pushed to 19.11.x branch for 19.11.04
choosing not to backport these to 19.05.x