`git grep PDF::API2::Simple` returns only one occurence, in cpanfile. `git log -S PDF::API2::Simple` returns a few commits that move around the declaration of dependencies, and the commit https://github.com/Koha-Community/Koha/commit/e418db57f9544983a004b6a7b7f79ab5bdcb30a0 that introduces this dependency without using it. So it looks like it has been a required dependency for 10 years, without ever being used.
Created attachment 98777 [details] [review] Bug 24647: Remove PDF::API2::Simple from cpanfile It is not used anywhere. Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile. These modules are included in PDF::API2 which is already in cpanfile.
Created attachment 99067 [details] [review] Bug 24647: Remove PDF::API2::Simple from cpanfile It is not used anywhere. Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile. These modules are included in PDF::API2 which is already in cpanfile. Test plan: 1) Search for PDF::API2::Simple - git grep PDF::API2::Simple - there should be one result 2) Apply the patch 3) Search again 4) There should be no results 5) Sign off! Signed-off-by: David Nind <david@davidnind.com>
Created attachment 99128 [details] [review] Bug 24647: Remove PDF::API2::Simple from cpanfile It is not used anywhere. Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile. These modules are included in PDF::API2 which is already in cpanfile. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
does not apply to 19.11.x cpanfile does not contain the lines indicated to be removed anyways! not backporting