https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 appears to have introduced a trivial little HTML error. Chrome seems to cope with it fine but probably better out than in.
Created attachment 99140 [details] [review] Bug 24676: Remove <p/> typo in opac-auth.tt This patch removes some trivial invalid HTML from opac-auth.tt Test plan: 1. Apply patch 2. As an unauthenticated user, try to place a hold on a search result e.g. http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=29 3. View source or use an inspector to see there is no <p></p> block between <input type="submit" value="Log in" class="btn"> and <div id="nologininstructions">
Created attachment 99326 [details] [review] Bug 24676: Remove <p/> typo in opac-auth.tt This patch removes some trivial invalid HTML from opac-auth.tt Test plan: 1. Apply patch 2. As an unauthenticated user, try to place a hold on a search result e.g. http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=29 3. View source or use an inspector to see there is no <p></p> block between <input type="submit" value="Log in" class="btn"> and <div id="nologininstructions"> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 99340 [details] [review] Bug 24676: Remove <p/> typo in opac-auth.tt This patch removes some trivial invalid HTML from opac-auth.tt Test plan: 1. Apply patch 2. As an unauthenticated user, try to place a hold on a search result e.g. http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=29 3. View source or use an inspector to see there is no <p></p> block between <input type="submit" value="Log in" class="btn"> and <div id="nologininstructions"> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial fix passes all tests.. passing qa
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x for 19.11.04
backported to 19.05.x for 19.05.09