Bug 24709 - Advanced editor - show space after delimiter visually
Summary: Advanced editor - show space after delimiter visually
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Cori Lynn Arnold
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-21 19:07 UTC by Cori Lynn Arnold
Modified: 2023-11-06 17:48 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 24709: Advanced editor - show space after delimiter visually (2.72 KB, patch)
2020-02-21 19:35 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 24709: Advanced editor - show space after delimiter visually (2.76 KB, patch)
2020-02-21 20:55 UTC, David Nind
Details | Diff | Splinter Review
Bug 24709: Advanced editor - show space after delimiter visually (2.76 KB, patch)
2020-03-03 22:02 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 24709: Advanced editor - show space after delimiter visually (2.76 KB, patch)
2020-03-03 22:19 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 24709: Advanced editor - show space after delimiter visually (2.76 KB, patch)
2020-03-03 22:23 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Bug 24709: Advanced editor - show space after delimiter visually (2.95 KB, patch)
2020-12-01 15:28 UTC, Cori Lynn Arnold
Details | Diff | Splinter Review
Correct Ubuntu versions in release notes - md (1.12 KB, text/plain)
2020-12-01 16:24 UTC, Cori Lynn Arnold
Details
Orange border missing for some subfields (117.21 KB, image/png)
2021-01-15 22:27 UTC, Barbara Johnson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cori Lynn Arnold 2020-02-21 19:07:23 UTC
Catalogers would like to visually see if there is a space after the delimiter in the Advanced editor, much like what was done for Bug 24452 - Advanced editor - show multiple spaces visually
Comment 1 Cori Lynn Arnold 2020-02-21 19:35:44 UTC Comment hidden (obsolete)
Comment 2 Cori Lynn Arnold 2020-02-21 19:36:11 UTC
Assigning to me.
Comment 3 David Nind 2020-02-21 20:55:58 UTC
Created attachment 99444 [details] [review]
Bug 24709: Advanced editor - show space after delimiter visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that a space immediately following a delimiter will be detected and
highlighted (green).

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

1) Go to Cataloging -> Advanced editor.
2) On any text entry line (e.g. 245), add a space immediately following
   the delimiter the space and delimiter should be highlighted green.
3) Remove the extra space and confirm that the highlight disappears.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2020-02-29 09:36:57 UTC
I totally agree with the idea of this, I am just wondering if the green highlighting works in terms of usability (easy to understand, what the problem is as green is usually a 'good thing')

I wonder if some red underlining would work better, thinking about how text processors like Word inform you of things to fix.

Adding Owen for an additional opinion. 

(Don't be scared by status change, I will come back to this!)
Comment 5 Cori Lynn Arnold 2020-02-29 20:30:51 UTC
The green was our head of cataloging choice. There's already red dotted lines for two spaces.
Comment 6 Lisette Scheer 2020-03-03 19:19:02 UTC
I agree with Katrin that green so often means good that it would be confusing. 
I checked in word and libreoffice and they both did blue underline for grammar errors. Maybe a blue highlight or underline would work here as well? 
Lisette
Comment 7 Cori Lynn Arnold 2020-03-03 19:21:38 UTC
I'm good with highlight blue. 

We'd like this to be a bit more prominent than underline, as it's an insidious problem and common for people converting from OCLC
Comment 8 Cori Lynn Arnold 2020-03-03 22:02:05 UTC
Created attachment 100080 [details] [review]
Bug 24709: Advanced editor - show space after delimiter visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that a space immediately following a delimiter will be detected and
highlighted (green).

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

  - Go to Cataloging -> Advanced editor.
  - On any text entry line (e.g. 245), add a space immediately following
  the delimiter the space and delimiter should be highlighted green.
  - Remove the extra space and confirm that the highlight
            disappears.
Comment 9 Cori Lynn Arnold 2020-03-03 22:19:34 UTC
Created attachment 100081 [details] [review]
Bug 24709: Advanced editor - show space after delimiter visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that a space immediately following a delimiter will be detected and
highlighted (green).

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

  - Go to Cataloging -> Advanced editor.
  - On any text entry line (e.g. 245), add a space immediately following
  the delimiter the space and delimiter should be highlighted green.
  - Remove the extra space and confirm that the highlight
            disappears.

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 Cori Lynn Arnold 2020-03-03 22:22:12 UTC
Bug 24709: Advanced editor - show space after delimiter visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that a space immediately following a delimiter will be surrounded by a red dotted border.

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

  - Go to Cataloging -> Advanced editor.
  - On any text entry line (e.g. 245), add a space immediately following
  the **delimiter the space and delimiter should be surrounded by a red dotted border.
  - Remove the extra space and confirm that the red dotted border is removed

**To create a delimiter in the advanced editor, go to a non-control field (after 010) and hit the control button with the letter "d" then enter any letter or single digit.
Comment 11 Cori Lynn Arnold 2020-03-03 22:23:52 UTC
Created attachment 100082 [details] [review]
Bug 24709: Advanced editor - show space after delimiter visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that a space immediately following a delimiter will be surrounded by a red dotted border.

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

  - Go to Cataloging -> Advanced editor.
    - On any text entry line (e.g. 245), add a space immediately following
      the **delimiter the space and delimiter should be surrounded by a red dotted border.
        - Remove the extra space and confirm that the red dotted border is removed

        **To create a delimiter in the advanced editor, go to a non-control field (after 010) and hit the control button with the letter "d" then enter any letter or single digit.
Comment 12 Cori Lynn Arnold 2020-03-03 22:30:30 UTC
Issues with my vm space is causing this not to work :(
Comment 13 Cori Lynn Arnold 2020-12-01 15:28:47 UTC
Created attachment 114079 [details] [review]
Bug 24709: Advanced editor - show space after delimiter visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that a space immediately following a delimiter will be surrounded by an orange dotted border.

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

  - Go to Cataloging -> Advanced editor.
      - On any text entry line (e.g. 245), add a space immediately following
            the **delimiter the space and delimiter should be surrounded by a red dotted border.
                    - Remove the extra space and confirm that the red dotted border is removed

                            **To create a delimiter in the advanced editor, go to a non-control field (after 010) and hit the control button with the letter "d" then enter any letter or single digit.
Comment 14 Cori Lynn Arnold 2020-12-01 16:24:39 UTC
Created attachment 114080 [details]
Correct Ubuntu versions in release notes - md

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 15 Cori Lynn Arnold 2020-12-01 16:46:18 UTC
This patch updates the JavaScript and CSS for the advanced MARC editor
so that a space immediately following a delimiter will be surrounded by an orange dotted border.

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

  - Go to Cataloging -> Advanced editor.
      - On any text entry line (e.g. 245), add a space immediately following
            the **delimiter the space and delimiter should be surrounded by a red dotted border.
      - Remove the extra space and confirm that the red dotted border is removed

**To create a delimiter in the advanced editor, go to a non-control field (after 010) and hit the control button with the letter "d" then enter any letter or single digit.
Comment 16 Barbara Johnson 2021-01-15 22:25:58 UTC
My test produced the orange dotted border for some subfields but not all of them.  For instance, it did not work for the subfield 'a' of a 100 or 245 tag.  Also, it did not work when a tag had only one subfield and it was not subfield 'a'.
Comment 17 Barbara Johnson 2021-01-15 22:27:26 UTC
Created attachment 115216 [details]
Orange border missing for some subfields