With OpacPublic disabled you are routed to http://localhost:8080/cgi-bin/koha/opac-main.pl?logout.x=1 upon logout. opac-auth.tt adds any inputs it is passed to the login form So you get: <input type="hidden" name="logout.x" value="1"> Login, and immediately get logged out
Created attachment 99453 [details] [review] Bug 24711: Don't add logout input to login form To test: 1 - Set OpacPublic syspref to 'Disable' 2 - Log in to OPAC 3 - Log out 4 - Try to log in again 5 - No error, but you get the login form again 6 - Apply patch 7 - Repeat 8 - This time you can log in again
Created attachment 99457 [details] [review] Bug 24711: Don't add logout input to login form To test: 1 - Set OpacPublic syspref to 'Disable' 2 - Log in to OPAC 3 - Log out 4 - Try to log in again 5 - No error, but you get the login form again 6 - Apply patch 7 - Repeat 8 - This time you can log in again Signed-off-by: David Nind <david@davidnind.com>
Created attachment 99466 [details] [review] Bug 24711: Don't add logout input to login form To test: 1 - Set OpacPublic syspref to 'Disable' 2 - Log in to OPAC 3 - Log out 4 - Try to log in again 5 - No error, but you get the login form again 6 - Apply patch 7 - Repeat 8 - This time you can log in again Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
pushed to 19.11.x branch for 19.11.05
backported to 19.05.x for 19.05.10
Backported to 18.11.x for 18.11.16