Currently we just use Dumper output directly, it would be helpful if we formatted things slightly
Created attachment 99605 [details] [review] Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort To test: 1 - Enable sysprefs DumpTemplateVarsOpac DumpTemplateVarsIntranet 2 - View some pages on staff client and opac 3 - View the page source 4 - See a large mass of comments including the page vars at the top of the source 5 - Refresh page and note order of vars changes 6 - Apply patch 7 - View page source on some pages and note things are much easier to read 8 - Refresh page and note variable order does not change
Created attachment 99682 [details] [review] Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort To test: 1 - Enable sysprefs DumpTemplateVarsOpac DumpTemplateVarsIntranet 2 - View some pages on staff client and opac 3 - View the page source 4 - See a large mass of comments including the page vars at the top of the source 5 - Refresh page and note order of vars changes 6 - Apply patch 7 - View page source on some pages and note things are much easier to read 8 - Refresh page and note variable order does not change Signed-off-by: George Williams <george@nekls.org>
Created attachment 99807 [details] [review] Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort To test: 1 - Enable sysprefs DumpTemplateVarsOpac DumpTemplateVarsIntranet 2 - View some pages on staff client and opac 3 - View the page source 4 - See a large mass of comments including the page vars at the top of the source 5 - Refresh page and note order of vars changes 6 - Apply patch 7 - View page source on some pages and note things are much easier to read 8 - Refresh page and note variable order does not change Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
enhancement no backported to 19.11.x
welp, i changed my mind. Nick asked so nicely that I applied to this to the 19.11.x branch for 19.11.05. :D
backported to 19.05.x for 19.05.10
Enhancement will not be backported to 18.11.x series