When an item is claimed returned by staff, there is a column called Updated On - this date field column should remain blank until this claimed returned has been updated. Currently, when an item has been claimed returned, the date in the updated column states 12/31/1969. This date only shows up in the display, it is doesn't show up in the database like this. Looking at other data tables with date columns that are blank - this display is not doing the same thing, such as Aqorders or Purchase Suggestions.
Created attachment 99923 [details] [review] Bug 24765: Updated on date in Claims returned starts off as 12/31/1969 When an item is claimed returned by staff, there is a column called Updated On - this date field column should remain blank until this claimed returned has been updated. Currently, when an item has been claimed returned, the date in the updated column states 12/31/1969. This date only shows up in the display, it is doesn't show up in the database like this. Test Plan: 1) Enable return claims 2) Make a claim 3) Note the 'updated on' column has the date 1969-12-31 4) Apply this patch 5) Reload the page ( you may need to clear your browser cache ) 6) Note the field is now blank
Created attachment 99924 [details] [review] Bug 24765: Updated on date in Claims returned starts off as 12/31/1969 When an item is claimed returned by staff, there is a column called Updated On - this date field column should remain blank until this claimed returned has been updated. Currently, when an item has been claimed returned, the date in the updated column states 12/31/1969. This date only shows up in the display, it is doesn't show up in the database like this. Test Plan: 1) Enable return claims 2) Make a claim 3) Note the 'updated on' column has the date 1969-12-31 4) Apply this patch 5) Reload the page ( you may need to clear your browser cache ) 6) Note the field is now blank
Should this be master in the version?
(In reply to Katrin Fischer from comment #3) > Should this be master in the version? IIRC I reproduced the bug on master. Does in no longer happen on master for you?
(In reply to Kyle M Hall from comment #4) > (In reply to Katrin Fischer from comment #3) > > Should this be master in the version? > > IIRC I reproduced the bug on master. Does in no longer happen on master for > you? The bug is filed for 19.11 - was just checking if we need to change this as it sounded like master. Did not test myself :)
Created attachment 101867 [details] [review] Bug 24765: Updated on date in Claims returned starts off as 12/31/1969 When an item is claimed returned by staff, there is a column called Updated On - this date field column should remain blank until this claimed returned has been updated. Currently, when an item has been claimed returned, the date in the updated column states 12/31/1969. This date only shows up in the display, it is doesn't show up in the database like this. Test Plan: 1) Enable return claims 2) Make a claim 3) Note the 'updated on' column has the date 1969-12-31 4) Apply this patch 5) Reload the page ( you may need to clear your browser cache ) 6) Note the field is now blank Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Confirmed as a bug on master (albeit with the date 01/01/1970). The patch works, so signing off.
Created attachment 101969 [details] [review] Bug 24765: Updated on date in Claims returned starts off as 12/31/1969 When an item is claimed returned by staff, there is a column called Updated On - this date field column should remain blank until this claimed returned has been updated. Currently, when an item has been claimed returned, the date in the updated column states 12/31/1969. This date only shows up in the display, it is doesn't show up in the database like this. Test Plan: 1) Enable return claims 2) Make a claim 3) Note the 'updated on' column has the date 1969-12-31 4) Apply this patch 5) Reload the page ( you may need to clear your browser cache ) 6) Note the field is now blank Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Hmm....
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x for 19.11.05
missing dependencies for 19.05.x, no backport