The new feature uses up quite a bit of space in the circulation screen, but will not be used by every library. Special libraries that only do in-house circulation to staff often ask us to remove things they don't need or want to use (such as all fine related things). It would be great if this new feature could be turned off.
Can you be more specific? If the syspref ClaimReturnedLostValue is empty, the feature should be disabled.
The ability to claim an item "claim returned" is not there if the syspref is empty, however, the Claim Returned tab is stil present on the patrons detail page.
Created attachment 100618 [details] [review] Bug 24767: "Claim returned" feature cannot be turned off The ability to claim an item "claim returned" is not there if the syspref is empty, however, the Claim Returned tab is stil present on the patrons detail page. Test Plan: 1) Ensure ClaimReturnedLostValue is not set 2) Note the claims tabs on the circulation and patron details pages 3) Apply this patch 4) Refresh those pages 5) The claims tabs should be gone!
Created attachment 100620 [details] [review] Bug 24767: "Claim returned" feature cannot be turned off The ability to claim an item "claim returned" is not there if the syspref is empty, however, the Claim Returned tab is stil present on the patrons detail page. Test Plan: 1) Ensure ClaimReturnedLostValue is not set 2) Note the claims tabs on the circulation and patron details pages 3) Apply this patch 4) Refresh those pages 5) The claims tabs should be gone! Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 100640 [details] [review] Bug 24767: Hide the "Claim returned" tab if the feature is turned off The ability to claim an item "claim returned" is not there if the syspref is empty, however, the Claim Returned tab is stil present on the patrons detail page. Test Plan: 1) Ensure ClaimReturnedLostValue is not set 2) Note the claims tabs on the circulation and patron details pages 3) Apply this patch 4) Refresh those pages 5) The claims tabs should be gone! Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Commit title amended.
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x branch for 19.11.05