While all other columns in the checkouts tables on the checkouts and details tab can be hidden by default using the column configuration page, this is not true for the new column "Return claims". I am filing this as a bug report as I think it's a necessary usability fix - not all libraries will be interested in this feature and the column takes up quite a lot of space. It would also help libraries using the feature as it's not a thing that you need all the time, so setting to 'hidden by default, but can togggle' will allow to make it visible when needed for use.
Created attachment 102787 [details] [review] Bug 24768: Add 'Return claims' to column configuration for checkouts tables The checkouts tables on the checkouts and details tabs in the staff patron account support column confiugration, but the new column "Return claims" was missing. This patch adds the column to the column configuration. To test: - Make sure to test with a patron having return claims and without - Verify cou can toggle the visibility of the return claims column from top of the tables in the checkouts and details tabs - Go to administrastion > column configuration - Change the settings for the issues tables in the Patrons and Circulation sections - Verify the changes have been applied to the tables as configured
I've applied this patch but I can't see any option to hide this column, either from the top of the table, or in the column configuration admin. What am I missing? My user has a claims returned.... https://snipboard.io/462alZ.jpg https://snipboard.io/YdK5xy.jpg
Thx for testing David, checking what's going on here!
Created attachment 102857 [details] [review] Bug 24768: Add 'Return claims' to column configuration for checkouts tables The checkouts tables on the checkouts and details tabs in the staff patron account support column confiugration, but the new column "Return claims" was missing. This patch adds the column to the column configuration. To test: - Make sure to test with a patron having return claims and without - Verify cou can toggle the visibility of the return claims column from top of the tables in the checkouts and details tabs - Go to administrastion > column configuration - Change the settings for the issues tables in the Patrons and Circulation sections - Verify the changes have been applied to the tables as configured
Hi David, I indeed forgot to commit a typo fix on the pref file, but from your screenshots it looks like a 'restart_all' might be missing or as if the patch hadn't been applied. Could you try again?
Created attachment 102870 [details] [review] Bug 24768: Add 'Return claims' to column configuration for checkouts tables The checkouts tables on the checkouts and details tabs in the staff patron account support column confiugration, but the new column "Return claims" was missing. This patch adds the column to the column configuration. To test: - Make sure to test with a patron having return claims and without - Verify cou can toggle the visibility of the return claims column from top of the tables in the checkouts and details tabs - Go to administrastion > column configuration - Change the settings for the issues tables in the Patrons and Circulation sections - Verify the changes have been applied to the tables as configured Signed-off-by: David Roberts <david@koha-ptfs.co.uk>
Thanks Katrin, works perfectly now.
Created attachment 103141 [details] [review] Bug 24768: Add 'Return claims' to column configuration for checkouts tables The checkouts tables on the checkouts and details tabs in the staff patron account support column confiugration, but the new column "Return claims" was missing. This patch adds the column to the column configuration. To test: - Make sure to test with a patron having return claims and without - Verify cou can toggle the visibility of the return claims column from top of the tables in the checkouts and details tabs - Go to administrastion > column configuration - Change the settings for the issues tables in the Patrons and Circulation sections - Verify the changes have been applied to the tables as configured Signed-off-by: David Roberts <david@koha-ptfs.co.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to master for 20.05
when running qa after applying to 19.11.x I am seeing a failing on POD coverage for the koha_object_class in course items, course reserves, and course instructor. Safe to ignore or fine to push to 19.11.x?
You can ignore the POD warnings.
Backported to 19.11.x for 19.11.06
Dependency is missing for 19.05.x, no backport